Bug 121086

Summary: Apply OVERRIDE and FINAL to Image subclasses and clean them up
Product: WebKit Reporter: Tim Horton <thorton>
Component: Layout and RenderingAssignee: Tim Horton <thorton>
Status: RESOLVED FIXED    
Severity: Normal CC: buildbot, commit-queue, d-r, fmalita, pdr, rniwa, schenney, simon.fraser
Priority: P2    
Version: 528+ (Nightly build)   
Hardware: Unspecified   
OS: Unspecified   
Bug Depends on: 121220    
Bug Blocks:    
Attachments:
Description Flags
patch
buildbot: commit-queue-
patch ap: review+

Tim Horton
Reported 2013-09-10 00:54:39 PDT
Image's subclasses are a bit messy and need some tidying, and are missing our new friends OVERRIDE and FINAL.
Attachments
patch (22.41 KB, patch)
2013-09-10 01:04 PDT, Tim Horton 		buildbot: commit-queue-
DetailsFormatted DiffDiff
patch (24.14 KB, patch)
2013-09-10 14:37 PDT, Tim Horton 		ap: review+
DetailsFormatted DiffDiff
Show Obsolete (1) View All Add attachment proposed patch, testcase, etc.
Tim Horton
Comment 1 2013-09-10 01:04:40 PDT
Created attachment 211183 [details] patch Maybe this should be a few patches, I don't know, I feel silly making lots of patches for this. Probably it will break other port's builds, but we'll see.
Tim Horton
Comment 2 2013-09-10 01:17:11 PDT
Comment on attachment 211183 [details] patch View in context: https://bugs.webkit.org/attachment.cgi?id=211183&action=review > Source/WebCore/platform/graphics/BitmapImage.h:-178 > -protected: It looks like this has been this way effectively forever. I wonder if there's a reason for it?
Build Bot
Comment 3 2013-09-10 01:26:37 PDT
Comment on attachment 211183 [details] patch Attachment 211183 [details] did not pass mac-wk2-ews (mac-wk2): Output: http://webkit-queues.appspot.com/results/1743156
Build Bot
Comment 4 2013-09-10 01:46:58 PDT
Comment on attachment 211183 [details] patch Attachment 211183 [details] did not pass mac-ews (mac): Output: http://webkit-queues.appspot.com/results/1763036
Tim Horton
Comment 5 2013-09-10 14:37:09 PDT
Created attachment 211245 [details] patch
Tim Horton
Comment 6 2013-09-12 02:24:43 PDT
Ugh, we really need to fix win-ews. This broke the windows build.
Note You need to log in before you can comment on or make changes to this bug.