| Summary: | Block "]]>" in createCDataSection | ||||||||||||
|---|---|---|---|---|---|---|---|---|---|---|---|---|---|
| Product: | WebKit | Reporter: | Ryosuke Niwa <rniwa> | ||||||||||
| Component: | New Bugs | Assignee: | Ryosuke Niwa <rniwa> | ||||||||||
| Status: | RESOLVED WONTFIX | ||||||||||||
| Severity: | Normal | CC: | ap, buildbot, cdumez, commit-queue, esprehn+autocc, kangil.han, rniwa, robert, rwlbuis | ||||||||||
| Priority: | P2 | Keywords: | BlinkMergeCandidate | ||||||||||
| Version: | 528+ (Nightly build) | ||||||||||||
| Hardware: | Unspecified | ||||||||||||
| OS: | Unspecified | ||||||||||||
| Attachments: |
|
||||||||||||
|
Description
Ryosuke Niwa
2013-09-09 19:12:24 PDT
Created attachment 211134 [details]
Fixes the bug
Created attachment 211135 [details]
Added the forgotten test
Comment on attachment 211135 [details] Added the forgotten test View in context: https://bugs.webkit.org/attachment.cgi?id=211135&action=review > Source/WebCore/ChangeLog:11 > + It's not possible to serialize a CData section with ]]> in it so disallow that already in xmldoc.createCDataSection. > + New behavior matches that of Trident and Gecko. What about appendData, insertData, replaceData and replaceWholeText? This change as made in Blink is pretty much useless alone. Comment on attachment 211135 [details] Added the forgotten test Attachment 211135 [details] did not pass mac-wk2-ews (mac-wk2): Output: http://webkit-queues.appspot.com/results/1736487 New failing tests: dom/xhtml/level3/core/documentnormalizedocument07.xhtml dom/xhtml/level3/core/documentnormalizedocument08.xhtml dom/xhtml/level3/core/handleerror01.xhtml dom/xhtml/level3/core/splitcdatasections01.xhtml Created attachment 211139 [details]
Archive of layout-test-results from webkit-ews-10 for mac-mountainlion-wk2
The attached test failures were seen while running run-webkit-tests on the mac-wk2-ews.
Bot: webkit-ews-10 Port: mac-mountainlion-wk2 Platform: Mac OS X 10.8.4
> dom/xhtml/level3/core/splitcdatasections01.xhtml
So this documents correct behavior.
Comment on attachment 211135 [details] Added the forgotten test Attachment 211135 [details] did not pass mac-ews (mac): Output: http://webkit-queues.appspot.com/results/1726773 New failing tests: dom/xhtml/level3/core/documentnormalizedocument07.xhtml dom/xhtml/level3/core/documentnormalizedocument08.xhtml dom/xhtml/level3/core/handleerror01.xhtml dom/xhtml/level3/core/splitcdatasections01.xhtml Created attachment 211144 [details]
Archive of layout-test-results from webkit-ews-05 for mac-mountainlion
The attached test failures were seen while running run-webkit-tests on the mac-ews.
Bot: webkit-ews-05 Port: mac-mountainlion Platform: Mac OS X 10.8.4
Comment on attachment 211135 [details]
Added the forgotten test
You're right. We should probably update other functions.
I'm not quite sure what DOM4 authors are trying to achieve here. Are all ways to create non-serializable documents being banned? createCDataSection() and replaceWholeText() have been dropped from the latest DOM living standard. appendData, insertData, replaceData are still there and do not say anything about blocking "]]>". WebKit still supports createCDataSection() and replaceWholeText() though. Okay. |