Summary: | Changed URL from WebResourceLoadDelegate's webView:resource:willSendRequest:... is ignored | ||||||
---|---|---|---|---|---|---|---|
Product: | WebKit | Reporter: | Dan Wood <dwood> | ||||
Component: | Page Loading | Assignee: | Graham Dennis <Graham.Dennis> | ||||
Status: | RESOLVED FIXED | ||||||
Severity: | Major | CC: | rwlbuis | ||||
Priority: | P2 | Keywords: | Regression | ||||
Version: | 420+ | ||||||
Hardware: | Mac | ||||||
OS: | OS X 10.4 | ||||||
Attachments: |
|
Description
Dan Wood
2007-01-03 15:41:29 PST
Created attachment 12233 [details]
patch 1
Patch 1.
Passes layout tests, but no layout test added, as to test this, you need to be able to create a WebResourceLoadDelegate.
The problem was that m_request isn't set until the end of ResourceLoader::willSendRequest(), and so oldURL was always empty. But even if we replace oldURL with m_originalURL (which is set at the start of ResourceLoader::load()), the newRequest is only updated if the new and old URLs are the same. This patch fixes both problems so that WebResourceLoadDelegates can now change URLs.
Comment on attachment 12233 [details]
patch 1
Looks good. Maybe we should put a WebResourceLoadDelegate into DumpRenderTree so we can test this.
r=me
Committed by Rob in revision 18646. |