Bug 121059

Summary:

Introduce WTF::createOwned

Product:

WebKit

Reporter:

Anders Carlsson <andersca>

Component:

New Bugs

Assignee:

Anders Carlsson <andersca>

Status:

RESOLVED FIXED

Severity:

Normal

CC:

benjamin, cmarcelo, commit-queue

Priority:

Version:

528+ (Nightly build)

Hardware:

Unspecified

OS:

Unspecified

Attachments:

Description	Flags
Patch	none
Patch	none

Anders Carlsson

Reported 2013-09-09 16:31:38 PDT

Introduce WTF::createOwned

Attachments
Patch (11.62 KB, patch) 2013-09-09 16:35 PDT, Anders Carlsson	no flags	Details Formatted Diff Diff
Patch (11.64 KB, patch) 2013-09-09 16:45 PDT, Anders Carlsson	no flags	Details Formatted Diff Diff
Show Obsolete (1) View All Add attachment proposed patch, testcase, etc.

Anders Carlsson

Comment 1 2013-09-09 16:35:03 PDT

Created attachment 211114 [details] Patch

Andreas Kling

Comment 2 2013-09-09 16:37:36 PDT

Comment on attachment 211114 [details] Patch This will be even nicer with variadic template support eventually :)

WebKit Commit Bot

Comment 3 2013-09-09 16:37:49 PDT

Attachment 211114 [details] did not pass style-queue: Failed to run "['Tools/Scripts/check-webkit-style', '--diff-files', u'Source/WTF/ChangeLog', u'Source/WTF/wtf/FilePrintStream.cpp', u'Source/WTF/wtf/FilePrintStream.h', u'Source/WTF/wtf/HashTable.h', u'Source/WTF/wtf/ListHashSet.h', u'Source/WTF/wtf/OwnPtr.h', u'Source/WTF/wtf/Threading.cpp', u'Source/WTF/wtf/ThreadingPthreads.cpp', u'Source/WTF/wtf/unicode/Collator.h', u'Source/WTF/wtf/unicode/CollatorDefault.cpp', u'Source/WTF/wtf/unicode/icu/CollatorICU.cpp']" exit_code: 1 Source/WTF/wtf/unicode/icu/CollatorICU.cpp:61: The return type should use PassOwnPtr instead of OwnPtr. [readability/pass_ptr] [5] Source/WTF/wtf/FilePrintStream.h:31: Alphabetical sorting problem. [build/include_order] [4] Source/WTF/wtf/unicode/CollatorDefault.cpp:48: The return type should use PassOwnPtr instead of OwnPtr. [readability/pass_ptr] [5] Source/WTF/wtf/FilePrintStream.cpp:44: The return type should use PassOwnPtr instead of OwnPtr. [readability/pass_ptr] [5] Source/WTF/wtf/OwnPtr.h:92: Missing spaces around && [whitespace/operators] [3] Source/WTF/wtf/OwnPtr.h:93: Missing spaces around && [whitespace/operators] [3] Total errors found: 6 in 11 files If any of these errors are false positives, please file a bug against check-webkit-style.

Anders Carlsson

Comment 4 2013-09-09 16:45:14 PDT

Created attachment 211117 [details] Patch

WebKit Commit Bot

Comment 5 2013-09-09 16:46:39 PDT

Attachment 211117 [details] did not pass style-queue: Failed to run "['Tools/Scripts/check-webkit-style', '--diff-files', u'Source/WTF/ChangeLog', u'Source/WTF/wtf/FilePrintStream.cpp', u'Source/WTF/wtf/FilePrintStream.h', u'Source/WTF/wtf/HashTable.h', u'Source/WTF/wtf/ListHashSet.h', u'Source/WTF/wtf/OwnPtr.h', u'Source/WTF/wtf/Threading.cpp', u'Source/WTF/wtf/ThreadingPthreads.cpp', u'Source/WTF/wtf/unicode/Collator.h', u'Source/WTF/wtf/unicode/CollatorDefault.cpp', u'Source/WTF/wtf/unicode/icu/CollatorICU.cpp']" exit_code: 1 Source/WTF/wtf/unicode/icu/CollatorICU.cpp:61: The return type should use PassOwnPtr instead of OwnPtr. [readability/pass_ptr] [5] Source/WTF/wtf/FilePrintStream.h:31: Alphabetical sorting problem. [build/include_order] [4] Source/WTF/wtf/unicode/CollatorDefault.cpp:48: The return type should use PassOwnPtr instead of OwnPtr. [readability/pass_ptr] [5] Source/WTF/wtf/FilePrintStream.cpp:44: The return type should use PassOwnPtr instead of OwnPtr. [readability/pass_ptr] [5] Source/WTF/wtf/OwnPtr.h:92: Missing spaces around && [whitespace/operators] [3] Source/WTF/wtf/OwnPtr.h:93: Missing spaces around && [whitespace/operators] [3] Total errors found: 6 in 11 files If any of these errors are false positives, please file a bug against check-webkit-style.

WebKit Commit Bot

Comment 6 2013-09-09 17:42:49 PDT

Comment on attachment 211117 [details] Patch Clearing flags on attachment: 211117 Committed r155407: <http://trac.webkit.org/changeset/155407>

WebKit Commit Bot

Comment 7 2013-09-09 17:42:51 PDT

All reviewed patches have been landed. Closing bug.

Note You need to log in before you can comment on or make changes to this bug.