Bug 121051

Summary: Hide node() below RenderSVGModelObject, use element() instead.
Product: WebKit Reporter: Andreas Kling <kling>
Component: SVGAssignee: Andreas Kling <kling>
Status: RESOLVED FIXED    
Severity: Normal CC: commit-queue, dino, d-r, esprehn+autocc, fmalita, glenn, kondapallykalyan, pdr, schenney, zimmermann
Priority: P2    
Version: 528+ (Nightly build)   
Hardware: Unspecified   
OS: Unspecified   
Attachments:
Description Flags
Patch none

Andreas Kling
Reported 2013-09-09 15:06:24 PDT
RenderSVGModelObject and subclasses only ever have SVGElement as their node(). Let's tighten this up.
Attachments
Patch (43.52 KB, patch)
2013-09-09 15:15 PDT, Andreas Kling 		no flags
DetailsFormatted DiffDiff
View All Add attachment proposed patch, testcase, etc.
Andreas Kling
Comment 1 2013-09-09 15:15:55 PDT
Created attachment 211102 [details] Patch
Antti Koivisto
Comment 2 2013-09-09 15:29:52 PDT
Comment on attachment 211102 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=211102&action=review > Source/WebCore/rendering/svg/RenderSVGModelObject.h:72 > + SVGElement* element() const { return toSVGElement(RenderObject::node()); } Going with svgElement() might make sense to clarify tighter typing.
WebKit Commit Bot
Comment 3 2013-09-09 16:01:38 PDT
Comment on attachment 211102 [details] Patch Clearing flags on attachment: 211102 Committed r155398: <http://trac.webkit.org/changeset/155398>
WebKit Commit Bot
Comment 4 2013-09-09 16:01:41 PDT
All reviewed patches have been landed. Closing bug.
Note You need to log in before you can comment on or make changes to this bug.