Bug 121038

Summary:

Hide node() below RenderLayerModelObject, use element() instead

Product:

WebKit

Reporter:

Antti Koivisto <koivisto>

Component:

Layout and Rendering

Assignee:

Nobody <webkit-unassigned>

Status:

RESOLVED FIXED

Severity:

Normal

CC:

commit-queue, philn, xan.lopez

Priority:

Version:

528+ (Nightly build)

Hardware:

Unspecified

OS:

Unspecified

Attachments:

Description	Flags
patch	hyatt: review+

Antti Koivisto

Reported 2013-09-09 12:22:49 PDT

Tighter typing.

Attachments
patch (120.20 KB, patch) 2013-09-09 12:35 PDT, Antti Koivisto	hyatt: review+	Details Formatted Diff Diff
View All Add attachment proposed patch, testcase, etc.

Antti Koivisto

Comment 1 2013-09-09 12:35:36 PDT

Created attachment 211066 [details] patch

WebKit Commit Bot

Comment 2 2013-09-09 12:36:59 PDT

Attachment 211066 [details] did not pass style-queue: Failed to run "['Tools/Scripts/check-webkit-style', '--diff-files', u'Source/WebCore/ChangeLog', u'Source/WebCore/accessibility/AccessibilityRenderObject.cpp', u'Source/WebCore/accessibility/AccessibilityTable.cpp', u'Source/WebCore/accessibility/AccessibilityTableCell.cpp', u'Source/WebCore/accessibility/AccessibilityTableColumn.cpp', u'Source/WebCore/editing/markup.cpp', u'Source/WebCore/html/HTMLTableCellElement.cpp', u'Source/WebCore/html/shadow/SliderThumbElement.cpp', u'Source/WebCore/page/Frame.cpp', u'Source/WebCore/rendering/RenderBlock.cpp', u'Source/WebCore/rendering/RenderBlock.h', u'Source/WebCore/rendering/RenderBlockFlow.cpp', u'Source/WebCore/rendering/RenderBlockFlow.h', u'Source/WebCore/rendering/RenderBlockLineLayout.cpp', u'Source/WebCore/rendering/RenderBox.cpp', u'Source/WebCore/rendering/RenderBox.h', u'Source/WebCore/rendering/RenderBoxModelObject.cpp', u'Source/WebCore/rendering/RenderBoxModelObject.h', u'Source/WebCore/rendering/RenderButton.cpp', u'Source/WebCore/rendering/RenderButton.h', u'Source/WebCore/rendering/RenderEmbeddedObject.cpp', u'Source/WebCore/rendering/RenderFileUploadControl.cpp', u'Source/WebCore/rendering/RenderFrame.cpp', u'Source/WebCore/rendering/RenderFrameBase.cpp', u'Source/WebCore/rendering/RenderFrameSet.cpp', u'Source/WebCore/rendering/RenderHTMLCanvas.cpp', u'Source/WebCore/rendering/RenderIFrame.cpp', u'Source/WebCore/rendering/RenderImage.cpp', u'Source/WebCore/rendering/RenderInline.cpp', u'Source/WebCore/rendering/RenderInline.h', u'Source/WebCore/rendering/RenderLayer.cpp', u'Source/WebCore/rendering/RenderLayerBacking.cpp', u'Source/WebCore/rendering/RenderLayerCompositor.cpp', u'Source/WebCore/rendering/RenderLayerFilterInfo.cpp', u'Source/WebCore/rendering/RenderLayerModelObject.cpp', u'Source/WebCore/rendering/RenderLayerModelObject.h', u'Source/WebCore/rendering/RenderListBox.cpp', u'Source/WebCore/rendering/RenderListItem.cpp', u'Source/WebCore/rendering/RenderMarquee.cpp', u'Source/WebCore/rendering/RenderMedia.cpp', u'Source/WebCore/rendering/RenderMediaControlElements.cpp', u'Source/WebCore/rendering/RenderMenuList.cpp', u'Source/WebCore/rendering/RenderMeter.cpp', u'Source/WebCore/rendering/RenderPart.cpp', u'Source/WebCore/rendering/RenderProgress.cpp', u'Source/WebCore/rendering/RenderReplaced.cpp', u'Source/WebCore/rendering/RenderSearchField.cpp', u'Source/WebCore/rendering/RenderSlider.cpp', u'Source/WebCore/rendering/RenderSnapshottedPlugIn.cpp', u'Source/WebCore/rendering/RenderTable.cpp', u'Source/WebCore/rendering/RenderTableCell.cpp', u'Source/WebCore/rendering/RenderTableCol.cpp', u'Source/WebCore/rendering/RenderTextControl.cpp', u'Source/WebCore/rendering/RenderTextControlMultiLine.cpp', u'Source/WebCore/rendering/RenderTextControlSingleLine.cpp', u'Source/WebCore/rendering/RenderThemeMac.mm', u'Source/WebCore/rendering/RenderTreeAsText.cpp', u'Source/WebCore/rendering/RenderVideo.cpp', u'Source/WebCore/rendering/RenderWidget.cpp', u'Source/WebCore/rendering/mathml/RenderMathMLFenced.cpp', u'Source/WebCore/rendering/mathml/RenderMathMLFraction.cpp', u'Source/WebCore/rendering/mathml/RenderMathMLOperator.cpp', u'Source/WebCore/rendering/mathml/RenderMathMLSpace.cpp', u'Source/WebCore/rendering/svg/RenderSVGForeignObject.cpp', u'Source/WebCore/rendering/svg/RenderSVGRoot.cpp', u'Source/WebCore/rendering/svg/RenderSVGText.cpp', u'Source/WebCore/rendering/svg/RenderSVGTextPath.cpp']" exit_code: 1 Source/WebCore/rendering/mathml/RenderMathMLOperator.cpp:162: Omit int when using unsigned [runtime/unsigned] [1] Total errors found: 1 in 66 files If any of these errors are false positives, please file a bug against check-webkit-style.

Dave Hyatt

Comment 3 2013-09-09 12:41:05 PDT

Comment on attachment 211066 [details] patch r=me, fix style error.

Antti Koivisto

Comment 4 2013-09-09 12:54:35 PDT

https://trac.webkit.org/r155374

Note You need to log in before you can comment on or make changes to this bug.