Summary: | Make RenderView anonymous | ||||||||||||
---|---|---|---|---|---|---|---|---|---|---|---|---|---|
Product: | WebKit | Reporter: | Antti Koivisto <koivisto> | ||||||||||
Component: | Layout and Rendering | Assignee: | Nobody <webkit-unassigned> | ||||||||||
Status: | RESOLVED FIXED | ||||||||||||
Severity: | Normal | CC: | aboxhall, apinheiro, buildbot, cfleizach, commit-queue, dmazzoni, d-r, esprehn+autocc, fmalita, glenn, hyatt, jdiggs, kling, kondapallykalyan, mario, pdr, rniwa, schenney, simon.fraser, tonikitoo | ||||||||||
Priority: | P2 | ||||||||||||
Version: | 528+ (Nightly build) | ||||||||||||
Hardware: | Unspecified | ||||||||||||
OS: | Unspecified | ||||||||||||
See Also: | https://bugs.webkit.org/show_bug.cgi?id=209112 | ||||||||||||
Attachments: |
|
Description
Antti Koivisto
2013-09-08 13:41:08 PDT
Created attachment 210991 [details]
for bots
Comment on attachment 210991 [details] for bots Attachment 210991 [details] did not pass mac-ews (mac): Output: http://webkit-queues.appspot.com/results/1730168 New failing tests: platform/mac/accessibility/webarea-can-set-focus.html inspector-protocol/layers/layers-for-node.html inspector-protocol/layers/layers-compositing-reasons.html inspector-protocol/layers/layers-anonymous.html inspector-protocol/layers/layers-reflected-content.html inspector-protocol/layers/layers-generated-content.html Created attachment 210997 [details]
Archive of layout-test-results from webkit-ews-08 for mac-mountainlion
The attached test failures were seen while running run-webkit-tests on the mac-ews.
Bot: webkit-ews-08 Port: mac-mountainlion Platform: Mac OS X 10.8.4
Comment on attachment 210991 [details] for bots Attachment 210991 [details] did not pass mac-wk2-ews (mac-wk2): Output: http://webkit-queues.appspot.com/results/1730177 New failing tests: platform/mac/accessibility/webarea-can-set-focus.html inspector-protocol/layers/layers-for-node.html inspector-protocol/layers/layers-compositing-reasons.html inspector-protocol/layers/layers-anonymous.html inspector-protocol/layers/layers-reflected-content.html inspector-protocol/layers/layers-generated-content.html Created attachment 210999 [details]
Archive of layout-test-results from webkit-ews-16 for mac-mountainlion-wk2
The attached test failures were seen while running run-webkit-tests on the mac-wk2-ews.
Bot: webkit-ews-16 Port: mac-mountainlion-wk2 Platform: Mac OS X 10.8.4
Created attachment 211019 [details]
patch
Although, I understand and agree with the reason for doing this, it adds some burden to call sites: it will be easier for a developer to forget to add a isReviewView check, in addition to renderer->node(), leading to unforeseen issues. Maybe there should be a helper to be called to do the trick? renderer::hasNodeOrIsRenderView() |