Bug 121013

Summary:

Make RenderView anonymous

Product:

WebKit

Reporter:

Antti Koivisto <koivisto>

Component:

Layout and Rendering

Assignee:

Nobody <webkit-unassigned>

Status:

RESOLVED FIXED

Severity:

Normal

CC:

aboxhall, apinheiro, buildbot, cfleizach, commit-queue, dmazzoni, d-r, esprehn+autocc, fmalita, glenn, hyatt, jdiggs, kling, kondapallykalyan, mario, pdr, rniwa, schenney, simon.fraser, tonikitoo

Priority:

Version:

528+ (Nightly build)

Hardware:

Unspecified

OS:

Unspecified

See Also:

https://bugs.webkit.org/show_bug.cgi?id=209112

Attachments:

Description	Flags
for bots	buildbot: commit-queue-
Archive of layout-test-results from webkit-ews-08 for mac-mountainlion	none
Archive of layout-test-results from webkit-ews-16 for mac-mountainlion-wk2	none
patch	darin: review+

Antti Koivisto

Reported 2013-09-08 13:41:08 PDT

All renderers should be associated with either Elements or Text nodes, or ne anonymous. We can then clean up things further.

Attachments
for bots (7.11 KB, patch) 2013-09-08 13:42 PDT, Antti Koivisto	buildbot: commit-queue-	Details Formatted Diff Diff
Archive of layout-test-results from webkit-ews-08 for mac-mountainlion (606.72 KB, application/zip) 2013-09-08 14:59 PDT, Build Bot	no flags	Details
Archive of layout-test-results from webkit-ews-16 for mac-mountainlion-wk2 (581.68 KB, application/zip) 2013-09-08 15:39 PDT, Build Bot	no flags	Details
patch (15.14 KB, patch) 2013-09-09 02:12 PDT, Antti Koivisto	darin: review+	Details Formatted Diff Diff
Show Obsolete (1) View All Add attachment proposed patch, testcase, etc.

Antti Koivisto

Comment 1 2013-09-08 13:42:04 PDT

Created attachment 210991 [details] for bots

Build Bot

Comment 2 2013-09-08 14:59:26 PDT

Comment on attachment 210991 [details] for bots Attachment 210991 [details] did not pass mac-ews (mac): Output: http://webkit-queues.appspot.com/results/1730168 New failing tests: platform/mac/accessibility/webarea-can-set-focus.html inspector-protocol/layers/layers-for-node.html inspector-protocol/layers/layers-compositing-reasons.html inspector-protocol/layers/layers-anonymous.html inspector-protocol/layers/layers-reflected-content.html inspector-protocol/layers/layers-generated-content.html

Build Bot

Comment 3 2013-09-08 14:59:28 PDT

Created attachment 210997 [details] Archive of layout-test-results from webkit-ews-08 for mac-mountainlion The attached test failures were seen while running run-webkit-tests on the mac-ews. Bot: webkit-ews-08 Port: mac-mountainlion Platform: Mac OS X 10.8.4

Build Bot

Comment 4 2013-09-08 15:39:00 PDT

Comment on attachment 210991 [details] for bots Attachment 210991 [details] did not pass mac-wk2-ews (mac-wk2): Output: http://webkit-queues.appspot.com/results/1730177 New failing tests: platform/mac/accessibility/webarea-can-set-focus.html inspector-protocol/layers/layers-for-node.html inspector-protocol/layers/layers-compositing-reasons.html inspector-protocol/layers/layers-anonymous.html inspector-protocol/layers/layers-reflected-content.html inspector-protocol/layers/layers-generated-content.html

Build Bot

Comment 5 2013-09-08 15:39:03 PDT

Created attachment 210999 [details] Archive of layout-test-results from webkit-ews-16 for mac-mountainlion-wk2 The attached test failures were seen while running run-webkit-tests on the mac-wk2-ews. Bot: webkit-ews-16 Port: mac-mountainlion-wk2 Platform: Mac OS X 10.8.4

Antti Koivisto

Comment 6 2013-09-09 02:12:45 PDT

Created attachment 211019 [details] patch

Antonio Gomes

Comment 7 2013-09-09 11:40:07 PDT

Although, I understand and agree with the reason for doing this, it adds some burden to call sites: it will be easier for a developer to forget to add a isReviewView check, in addition to renderer->node(), leading to unforeseen issues. Maybe there should be a helper to be called to do the trick? renderer::hasNodeOrIsRenderView()

Antti Koivisto

Comment 8 2013-09-09 12:21:27 PDT

https://trac.webkit.org/r155370

Note You need to log in before you can comment on or make changes to this bug.