Summary: | JNI bindings should be available to non-Mac platforms that have JNI | ||||||||
---|---|---|---|---|---|---|---|---|---|
Product: | WebKit | Reporter: | David Carson <dacarson> | ||||||
Component: | JavaScriptCore | Assignee: | David Carson <dacarson> | ||||||
Status: | RESOLVED FIXED | ||||||||
Severity: | Normal | ||||||||
Priority: | P2 | ||||||||
Version: | 420+ | ||||||||
Hardware: | Other | ||||||||
OS: | Other | ||||||||
Attachments: |
|
Description
David Carson
2007-01-03 09:00:03 PST
Created attachment 12188 [details]
Patch to JavaScriptCore bindings
Comment from weinig: weinig: dacarson: we have a HAVE() macro in wtf/Platform.h that you should use instead of the plain #if [1:49pm] weinig: it does [1:49pm] dacarson: I was wondering about that - I'll take a look and switch it. [1:49pm] weinig: #define HAVE(WTF_FEATURE) (defined( HAVE_##WTF_FEATURE ) && HAVE_##WTF_FEATURE) [1:49pm] mitzpettel: adele: is there an "official" prefix for native slider bugs? [1:50pm] weinig: so all you need to do is #if HAVE(JNI) Created attachment 12195 [details]
Updated patch to address weinig's comments
Comment on attachment 12195 [details]
Updated patch to address weinig's comments
There's a tab in the change log. Otherwise looks fine.
r=me
Committed revision 18657. |