Bug 120964

Summary: Get rid of PassOwnArrayPtr
Product: WebKit Reporter: Anders Carlsson <andersca>
Component: New BugsAssignee: Anders Carlsson <andersca>
Status: RESOLVED FIXED    
Severity: Normal CC: benjamin, cmarcelo, commit-queue, dino, eric.carlson, esprehn+autocc, glenn, gyuyoung.kim, jer.noble, kondapallykalyan, luiz, noam, rakuco
Priority: P2    
Version: 528+ (Nightly build)   
Hardware: Unspecified   
OS: Unspecified   
Attachments:
Description Flags
Patch
none
Patch kling: review+

Anders Carlsson
Reported 2013-09-07 13:30:29 PDT
Get rid of PassOwnArrayPtr
Attachments
Patch (30.17 KB, patch)
2013-09-07 13:33 PDT, Anders Carlsson 		no flags
DetailsFormatted DiffDiff
Patch (33.20 KB, patch)
2013-09-07 13:46 PDT, Anders Carlsson 		kling: review+
DetailsFormatted DiffDiff
Show Obsolete (1) View All Add attachment proposed patch, testcase, etc.
Anders Carlsson
Comment 1 2013-09-07 13:33:02 PDT
Created attachment 210919 [details] Patch
Anders Carlsson
Comment 2 2013-09-07 13:46:43 PDT
Created attachment 210922 [details] Patch
WebKit Commit Bot
Comment 3 2013-09-07 14:34:03 PDT
Attachment 210922 [details] did not pass style-queue: Failed to run "['Tools/Scripts/check-webkit-style', '--diff-files', u'Source/JavaScriptCore/ChangeLog', u'Source/JavaScriptCore/bytecompiler/BytecodeGenerator.cpp', u'Source/JavaScriptCore/runtime/SymbolTable.h', u'Source/WTF/ChangeLog', u'Source/WTF/GNUmakefile.list.am', u'Source/WTF/WTF.pro', u'Source/WTF/WTF.vcxproj/WTF.vcxproj', u'Source/WTF/WTF.vcxproj/WTF.vcxproj.filters', u'Source/WTF/WTF.xcodeproj/project.pbxproj', u'Source/WTF/wtf/Assertions.cpp', u'Source/WTF/wtf/CMakeLists.txt', u'Source/WTF/wtf/DateMath.h', u'Source/WTF/wtf/FastBitVector.h', u'Source/WTF/wtf/Forward.h', u'Source/WTF/wtf/OwnArrayPtr.h', u'Source/WTF/wtf/PassOwnArrayPtr.h', u'Source/WebCore/ChangeLog', u'Source/WebCore/html/canvas/WebGLRenderingContext.cpp', u'Source/WebCore/platform/Length.cpp', u'Source/WebCore/platform/Length.h', u'Source/WebCore/platform/audio/FFTFrame.h', u'Source/WebCore/platform/graphics/GraphicsContext3D.cpp', u'Source/WebCore/platform/graphics/GraphicsContext3D.h', u'Source/WebCore/platform/graphics/texmap/TextureMapperGL.cpp', u'Source/WebCore/platform/graphics/wince/SharedBitmap.cpp', u'Source/WebKit2/ChangeLog', u'Source/WebKit2/Shared/ImmutableArray.h', u'Source/WebKit2/WebProcess/InjectedBundle/InjectedBundle.cpp', u'Tools/TestWebKitAPI/PlatformUtilities.cpp', u'Tools/WebKitTestRunner/InjectedBundle/TestRunner.cpp', u'Tools/WebKitTestRunner/StringFunctions.h', u'Tools/WebKitTestRunner/TestInvocation.cpp', u'Tools/WebKitTestRunner/efl/EventSenderProxyEfl.cpp', u'Tools/WebKitTestRunner/gtk/EventSenderProxyGtk.cpp']" exit_code: 1 Source/WTF/wtf/OwnArrayPtr.h:39: Missing spaces around && [whitespace/operators] [3] Source/WTF/wtf/OwnArrayPtr.h:61: Missing spaces around && [whitespace/operators] [3] Total errors found: 2 in 10 files If any of these errors are false positives, please file a bug against check-webkit-style.
Anders Carlsson
Comment 4 2013-09-07 15:15:15 PDT
Committed r155262: <http://trac.webkit.org/changeset/155262>
Note You need to log in before you can comment on or make changes to this bug.