Bug 120913

Summary: Make Obj-C bindings generator less #include-happy.
Product: WebKit Reporter: Andreas Kling <kling>
Component: WebCore Misc.Assignee: Andreas Kling <kling>
Status: RESOLVED FIXED    
Severity: Normal CC: cdumez, commit-queue, eric.carlson, glenn, jer.noble, kling
Priority: P2    
Version: 528+ (Nightly build)   
Hardware: Unspecified   
OS: Unspecified   
Attachments:
Description Flags
Patch
andersca: review+
Lander kling: commit-queue+

Description Andreas Kling 2013-09-06 17:28:25 PDT
Make Obj-C bindings generator less #include-happy.
Comment 1 Andreas Kling 2013-09-06 17:32:52 PDT
Created attachment 210821 [details]
Patch
Comment 2 WebKit Commit Bot 2013-09-06 17:35:45 PDT
Attachment 210821 [details] did not pass style-queue:

Failed to run "['Tools/Scripts/check-webkit-style', '--diff-files', u'Source/WebCore/ChangeLog', u'Source/WebCore/bindings/scripts/CodeGeneratorObjC.pm', u'Source/WebCore/bindings/scripts/test/ObjC/DOMTestActiveDOMObject.mm', u'Source/WebCore/bindings/scripts/test/ObjC/DOMTestCallback.mm', u'Source/WebCore/bindings/scripts/test/ObjC/DOMTestCustomNamedGetter.mm', u'Source/WebCore/bindings/scripts/test/ObjC/DOMTestEventConstructor.mm', u'Source/WebCore/bindings/scripts/test/ObjC/DOMTestEventTarget.mm', u'Source/WebCore/bindings/scripts/test/ObjC/DOMTestException.mm', u'Source/WebCore/bindings/scripts/test/ObjC/DOMTestInterface.mm', u'Source/WebCore/bindings/scripts/test/ObjC/DOMTestMediaQueryListListener.mm', u'Source/WebCore/bindings/scripts/test/ObjC/DOMTestNamedConstructor.mm', u'Source/WebCore/bindings/scripts/test/ObjC/DOMTestNode.mm', u'Source/WebCore/bindings/scripts/test/ObjC/DOMTestObj.mm', u'Source/WebCore/bindings/scripts/test/ObjC/DOMTestOverloadedConstructors.mm', u'Source/WebCore/bindings/scripts/test/ObjC/DOMTestSerializedScriptValueInterface.mm', u'Source/WebCore/bindings/scripts/test/ObjC/DOMTestTypedefs.mm']" exit_code: 1
Source/WebCore/ChangeLog:16:  Need whitespace between colon and description  [changelog/filechangedescriptionwhitespace] [5]
Total errors found: 1 in 2 files


If any of these errors are false positives, please file a bug against check-webkit-style.
Comment 3 Andreas Kling 2013-09-06 18:10:08 PDT
Created attachment 210824 [details]
Lander
Comment 4 Andreas Kling 2013-09-06 19:37:16 PDT
Committed r155233: <http://trac.webkit.org/changeset/155233>