Bug 120898 – Stop using fastNew/fastDelete in JavaScriptCore

• Component: New Bugs
• Status: RESOLVED FIXED

[Anders Carlsson]

Stop using fastNew/fastDelete in JavaScriptCore

[Anders Carlsson]

Created attachment 210804 [details]
Patch

[Andreas Kling]

Comment on attachment 210804 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=210804&action=review

> Source/JavaScriptCore/runtime/VM.cpp:160
> +    , arrayConstructorTable(adoptPtr(new HashTable(JSC::arrayConstructorTable)))
> +    , arrayPrototypeTable(adoptPtr(new HashTable(JSC::arrayPrototypeTable)))
> +    , booleanPrototypeTable(adoptPtr(new HashTable(JSC::booleanPrototypeTable)))

Perhaps we should add a HashTable::create() helper that returns a PassOwnPtr?
We don't want to put these on the stack anywhere right?

> Source/JavaScriptCore/runtime/VM.h:227
> +        OwnPtr<const HashTable> arrayConstructorTable;
> +        OwnPtr<const HashTable> arrayPrototypeTable;
> +        OwnPtr<const HashTable> booleanPrototypeTable;

You could make these "const OwnPtr<const HashTable>" to prevent changes post-construction.

[Anders Carlsson]

(In reply to comment #2)
> (From update of attachment 210804 [details])
> View in context: https://bugs.webkit.org/attachment.cgi?id=210804&action=review
> 
> > Source/JavaScriptCore/runtime/VM.cpp:160
> > +    , arrayConstructorTable(adoptPtr(new HashTable(JSC::arrayConstructorTable)))
> > +    , arrayPrototypeTable(adoptPtr(new HashTable(JSC::arrayPrototypeTable)))
> > +    , booleanPrototypeTable(adoptPtr(new HashTable(JSC::booleanPrototypeTable)))
> 
> Perhaps we should add a HashTable::create() helper that returns a PassOwnPtr?
> We don't want to put these on the stack anywhere right?

I’d rather we add a makeOwned function template so you can do

arrayConstructorTable(makeOwned<HashTable>())

and have things just work. I want to do that after we’ve gotten rid of PassOwnPtr though.

> 
> > Source/JavaScriptCore/runtime/VM.h:227
> > +        OwnPtr<const HashTable> arrayConstructorTable;
> > +        OwnPtr<const HashTable> arrayPrototypeTable;
> > +        OwnPtr<const HashTable> booleanPrototypeTable;
> 
> You could make these "const OwnPtr<const HashTable>" to prevent changes post-construction.

Good idea!

[Anders Carlsson]

Committed r155219: <http://trac.webkit.org/changeset/155219>