Bug 120887 – unicode-bidi: plaintext is treating embedded unicode-bidi: isolate incorrectly

• Component: Layout and Rendering
• Status: NEW

[Ryosuke Niwa]

Consider merging https://chromium.googlesource.com/chromium/blink/+/94d6a1596c23fd75bfb3ea0944c57ce28aee7d1b

In the CSS Writing Modes specification:
for the purpose of bidi resolution in its containing bidi paragraph,
the sequence is treated as if it were a single Object Replacement Character (U+FFFC).

However Blink does not treat the isolated sequence as if it were a U+UFFFC.
This patch adds a new method called bidiFirstSkippingIsolated that is used to get the
first nested bidi not isolated.

[Igor Trindade Oliveira]

Related bug: https://bugs.webkit.org/show_bug.cgi?id=84543

[Myles C. Maxfield]

Created attachment 211131 [details]
Patch

[Build Bot]

Comment on attachment 211131 [details]
Patch

Attachment 211131 [details] did not pass mac-ews (mac):
Output: http://webkit-queues.appspot.com/results/1742245

New failing tests:
fast/text/international/unicode-bidi-plaintext-inline-around-inline-isolate.html
fast/text/international/unicode-bidi-plaintext-inline-around-inline-plaintext.html

[Build Bot]

Created attachment 211141 [details]
Archive of layout-test-results from webkit-ews-08 for mac-mountainlion

The attached test failures were seen while running run-webkit-tests on the mac-ews.
Bot: webkit-ews-08  Port: mac-mountainlion  Platform: Mac OS X 10.8.4

[Igor Trindade Oliveira]

The test is failing because this patch 
https://src.chromium.org/viewvc/blink?revision=156261&view=revision needs to be applied first.

[Build Bot]

Comment on attachment 211131 [details]
Patch

Attachment 211131 [details] did not pass mac-ews (mac):
Output: http://webkit-queues.appspot.com/results/1728599

New failing tests:
fast/text/international/unicode-bidi-plaintext-inline-around-inline-isolate.html
fast/text/international/unicode-bidi-plaintext-inline-around-inline-plaintext.html

[Build Bot]

Created attachment 211151 [details]
Archive of layout-test-results from webkit-ews-03 for mac-mountainlion

The attached test failures were seen while running run-webkit-tests on the mac-ews.
Bot: webkit-ews-03  Port: mac-mountainlion  Platform: Mac OS X 10.8.4

[Build Bot]

Comment on attachment 211131 [details]
Patch

Attachment 211131 [details] did not pass mac-wk2-ews (mac-wk2):
Output: http://webkit-queues.appspot.com/results/1731588

New failing tests:
fast/text/international/unicode-bidi-plaintext-inline-around-inline-isolate.html
fast/text/international/unicode-bidi-plaintext-inline-around-inline-plaintext.html

[Build Bot]

Created attachment 211156 [details]
Archive of layout-test-results from webkit-ews-14 for mac-mountainlion-wk2

The attached test failures were seen while running run-webkit-tests on the mac-wk2-ews.
Bot: webkit-ews-14  Port: mac-mountainlion-wk2  Platform: Mac OS X 10.8.4

[Sam Weinig]

Comment on attachment 211131 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=211131&action=review

> Source/WebCore/ChangeLog:10
> +        However Blink does not treat the isolated sequence as if it were a U+UFFFC.

I am unclear on why Blink is mentioned here.

> Source/WebCore/ChangeLog:29
> +        * rendering/RenderBlockLineLayout.cpp:
> +        (WebCore::firstRenderObjectForDirectionalityDetermination):
> +        (WebCore::determinePlaintextDirectionality):
> +        (WebCore::constructBidiRunsForSegment):
> +        (WebCore::RenderBlock::layoutRunsAndFloatsInRange):
> +        (WebCore::RenderBlock::determineStartPosition):

Please add a per-function explanation of the change.

[Ryosuke Niwa]

Comment on attachment 211131 [details]
Patch

Clearing r? flag from an old patch.  Please upload a new patch for ToT.