| Summary: | MediaStream API: Moving Add/Remove track from WebMediaStreamCenterClient to WebMediaStream | ||||||||
|---|---|---|---|---|---|---|---|---|---|
| Product: | WebKit | Reporter: | Eric Carlson <eric.carlson> | ||||||
| Component: | WebCore Misc. | Assignee: | Eric Carlson <eric.carlson> | ||||||
| Status: | RESOLVED FIXED | ||||||||
| Severity: | Normal | CC: | buildbot, commit-queue, dino, glenn, hta, jer.noble, rniwa, tommyw | ||||||
| Priority: | P2 | Keywords: | BlinkMergeCandidate | ||||||
| Version: | 528+ (Nightly build) | ||||||||
| Hardware: | Unspecified | ||||||||
| OS: | Unspecified | ||||||||
| Bug Depends on: | |||||||||
| Bug Blocks: | 121101 | ||||||||
| Attachments: |
|
||||||||
|
Description
Eric Carlson
2013-09-06 11:45:58 PDT
Created attachment 210918 [details]
Proposed patch
Comment on attachment 210918 [details] Proposed patch Attachment 210918 [details] did not pass mac-wk2-ews (mac-wk2): Output: http://webkit-queues.appspot.com/results/1714648 New failing tests: fast/workers/termination-with-port-messages.html Created attachment 210926 [details]
Archive of layout-test-results from webkit-ews-13 for mac-mountainlion-wk2
The attached test failures were seen while running run-webkit-tests on the mac-wk2-ews.
Bot: webkit-ews-13 Port: mac-mountainlion-wk2 Platform: Mac OS X 10.8.4
(In reply to comment #3) > Created an attachment (id=210926) [details] > Archive of layout-test-results from webkit-ews-13 for mac-mountainlion-wk2 > > The attached test failures were seen while running run-webkit-tests on the mac-wk2-ews. > Bot: webkit-ews-13 Port: mac-mountainlion-wk2 Platform: Mac OS X 10.8.4 Unexpected flakiness: text-only failures (2) http/tests/inspector/inspect-element.html [ Failure Pass ] inspector/storage-panel-dom-storage-update.html [ Failure Pass ] Regressions: Unexpected crashes (1) fast/workers/termination-with-port-messages.html [ Crash ] These have nothing to do with this patch. Comment on attachment 210918 [details]
Proposed patch
LGTM. r=me.
Comment on attachment 210918 [details] Proposed patch Clearing flags on attachment: 210918 Committed r155362: <http://trac.webkit.org/changeset/155362> All reviewed patches have been landed. Closing bug. |