Bug 120798

Summary: FrameLoader: Convert three little loops to using Vector<Ref<Frame>>.
Product: WebKit Reporter: Andreas Kling <kling>
Component: Page LoadingAssignee: Andreas Kling <kling>
Status: RESOLVED FIXED    
Severity: Normal CC: commit-queue, japhet, kling, koivisto
Priority: P2    
Version: 528+ (Nightly build)   
Hardware: Unspecified   
OS: Unspecified   
Attachments:
Description Flags
Patch none

Description Andreas Kling 2013-09-05 14:42:16 PDT
FrameLoader: Convert three little loops to using Vector<Ref<Frame>>.
Comment 1 Andreas Kling 2013-09-05 14:45:43 PDT
Created attachment 210666 [details]
Patch
Comment 2 Antti Koivisto 2013-09-05 14:53:04 PDT
Comment on attachment 210666 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=210666&action=review

> Source/WebCore/loader/FrameLoader.cpp:2323
>      for (Frame* child = m_frame.tree().lastChild(); child; child = child->tree().previousSibling())

These look bit last season. Wonder if we should add FrameIterator?
Comment 3 Andreas Kling 2013-09-05 18:06:18 PDT
(In reply to comment #2)
> (From update of attachment 210666 [details])
> View in context: https://bugs.webkit.org/attachment.cgi?id=210666&action=review
> 
> > Source/WebCore/loader/FrameLoader.cpp:2323
> >      for (Frame* child = m_frame.tree().lastChild(); child; child = child->tree().previousSibling())
> 
> These look bit last season. Wonder if we should add FrameIterator?

That sounds like fun.
Comment 4 WebKit Commit Bot 2013-09-05 18:33:06 PDT
Comment on attachment 210666 [details]
Patch

Clearing flags on attachment: 210666

Committed r155168: <http://trac.webkit.org/changeset/155168>
Comment 5 WebKit Commit Bot 2013-09-05 18:33:08 PDT
All reviewed patches have been landed.  Closing bug.