Bug 120791

Summary: DRY out srcset related deviceScaleFactor calculations
Product: WebKit Reporter: Yoav Weiss <yoav>
Component: New BugsAssignee: Nobody <webkit-unassigned>
Status: RESOLVED FIXED    
Severity: Normal CC: commit-queue, esprehn+autocc, kangil.han
Priority: P2    
Version: 528+ (Nightly build)   
Hardware: Unspecified   
OS: Unspecified   
Attachments:
Description Flags
Patch none

Yoav Weiss
Reported 2013-09-05 13:30:28 PDT
DRY out srcset related deviceScaleFactor calculations
Attachments
Patch (5.45 KB, patch)
2013-09-05 13:38 PDT, Yoav Weiss 		no flags
DetailsFormatted DiffDiff
View All Add attachment proposed patch, testcase, etc.
Yoav Weiss
Comment 1 2013-09-05 13:38:41 PDT
Created attachment 210656 [details] Patch
Yoav Weiss
Comment 2 2013-09-05 14:18:46 PDT
Identical deviceScaleFactor calculations were performed in 3 different locations. I've added that calculation as a method of Document and replaced previous calculations by calls to this method.
Andreas Kling
Comment 3 2013-09-05 22:21:05 PDT
Comment on attachment 210656 [details] Patch r=me
WebKit Commit Bot
Comment 4 2013-09-05 22:47:41 PDT
Comment on attachment 210656 [details] Patch Clearing flags on attachment: 210656 Committed r155176: <http://trac.webkit.org/changeset/155176>
WebKit Commit Bot
Comment 5 2013-09-05 22:47:45 PDT
All reviewed patches have been landed. Closing bug.
Note You need to log in before you can comment on or make changes to this bug.