Bug 120788

Summary:

[Qt][BlackBerry] Text track localized string functions are named wrong

Product:

WebKit

Reporter:

Brendan Long <b.long>

Component:

New Bugs

Assignee:

Nobody <webkit-unassigned>

Status:

RESOLVED FIXED

Severity:

Normal

CC:

b.long, commit-queue, pnormand

Priority:

Version:

528+ (Nightly build)

Hardware:

Unspecified

OS:

Unspecified

Attachments:

Description	Flags
Patch	none
Fix ChangeLog	none

Description Brendan Long 2013-09-05 12:43:11 PDT

[Qt][BlackBerry] Text track localized string functions are named wrong

Comment 1 Brendan Long 2013-09-05 12:44:51 PDT

Created attachment 210648 [details]
Patch

This fixes the QtWebKitBuild with --video-track. I noticed BlackBerry had the same problem, so I fixed it there too. I'm going to look into building with --video-track by default and disabling it at runtime, since this comes up a lot. This specific case appears to have been caused by r155048.

Comment 2 Philippe Normand 2013-09-05 22:21:28 PDT

Comment on attachment 210648 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=210648&action=review

> Source/WebCore/ChangeLog:8
> +        No new tests (OOPS!).

cq won't like this, please remove it. Also if no details are given about the specific changes please remove the lines below.

Comment 3 Brendan Long 2013-09-06 08:54:51 PDT

Created attachment 210760 [details]
Fix ChangeLog

Comment 4 WebKit Commit Bot 2013-09-06 09:11:33 PDT

Comment on attachment 210760 [details]
Fix ChangeLog

Clearing flags on attachment: 210760

Committed r155190: <http://trac.webkit.org/changeset/155190>

Comment 5 WebKit Commit Bot 2013-09-06 09:11:35 PDT

All reviewed patches have been landed.  Closing bug.