Bug 120787

Summary:

Make RenderBlock have a protected constructor.

Product:

WebKit

Reporter:

Dave Hyatt <hyatt>

Component:

Layout and Rendering

Assignee:

Dave Hyatt <hyatt>

Status:

RESOLVED FIXED

Severity:

Normal

CC:

bdakin, commit-queue, esprehn+autocc, glenn, kondapallykalyan, ossy

Priority:

Version:

528+ (Nightly build)

Hardware:

Unspecified

OS:

Unspecified

Attachments:

Description	Flags
Patch	bdakin: review+

Dave Hyatt

Reported 2013-09-05 12:37:14 PDT

Make RenderBlock have a protected constructor so that it cannot be instantiated directly.

Attachments
Patch (4.38 KB, patch) 2013-09-05 12:41 PDT, Dave Hyatt	bdakin: review+	Details Formatted Diff Diff
View All Add attachment proposed patch, testcase, etc.

Dave Hyatt

Comment 1 2013-09-05 12:41:57 PDT

Dave Hyatt

Comment 2 2013-09-05 12:46:44 PDT

Landed in r155141.

Beth Dakin

Comment 3 2013-09-05 17:29:38 PDT

I had to roll this out with http://trac.webkit.org/changeset/155162 because of the failing tests.

Csaba Osztrogonác

Comment 4 2013-09-05 21:20:57 PDT

(In reply to comment #3) > I had to roll this out with http://trac.webkit.org/changeset/155162 because of the failing tests. Reopen, since it was rolled out.

Dave Hyatt

Comment 5 2013-09-06 13:55:46 PDT

Re-landed this in r155211..

Note You need to log in before you can comment on or make changes to this bug.