Bug 120779

Summary: Move Floats out of RenderBlock
Product: WebKit Reporter: Bem Jones-Bey <bjonesbe>
Component: Layout and RenderingAssignee: Bem Jones-Bey <bjonesbe>
Status: RESOLVED FIXED    
Severity: Normal CC: commit-queue, esprehn+autocc, glenn, gyuyoung.kim, kondapallykalyan, rakuco
Priority: P2    
Version: 528+ (Nightly build)   
Hardware: Unspecified   
OS: Unspecified   
Bug Depends on: 120705    
Bug Blocks:    
Attachments:
Description Flags
Patch
none
Patch
none
Patch
none
Patch none

Bem Jones-Bey
Reported 2013-09-05 10:24:58 PDT
Move Floats out of RenderBlock
Attachments
Patch (64.89 KB, patch)
2013-09-05 10:38 PDT, Bem Jones-Bey 		no flags
DetailsFormatted DiffDiff
Patch (64.83 KB, patch)
2013-09-09 13:22 PDT, Bem Jones-Bey 		no flags
DetailsFormatted DiffDiff
Patch (65.49 KB, patch)
2013-09-09 13:55 PDT, Bem Jones-Bey 		no flags
DetailsFormatted DiffDiff
Patch (65.49 KB, patch)
2013-09-09 14:03 PDT, Bem Jones-Bey 		no flags
DetailsFormatted DiffDiff
Show Obsolete (3) View All Add attachment proposed patch, testcase, etc.
Bem Jones-Bey
Comment 1 2013-09-05 10:38:16 PDT
Created attachment 210634 [details] Patch This will not apply until the patch in bug 120705 lands.
Bem Jones-Bey
Comment 2 2013-09-09 13:22:39 PDT
Created attachment 211073 [details] Patch Rebase
Alexandru Chiculita
Comment 3 2013-09-09 13:31:36 PDT
Comment on attachment 211073 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=211073&action=review r=me > Source/WebCore/rendering/FloatingObjects.cpp:51 > + : m_renderer(renderer) nit: Fix indentation for the initializers. > Source/WebCore/rendering/FloatingObjects.cpp:84 > +: m_placedFloatsTree(UninitializedTree) Nit: ditto > Source/WebCore/rendering/FloatingObjects.h:45 > + : m_renderer(0) nit: ditto > Source/WebCore/rendering/FloatingObjects.h:63 > + : m_renderer(0) nit: ditto
Bem Jones-Bey
Comment 4 2013-09-09 13:55:46 PDT
Created attachment 211080 [details] Patch Rebase again!
Bem Jones-Bey
Comment 5 2013-09-09 14:03:40 PDT
Created attachment 211081 [details] Patch This time with reviewer name!
WebKit Commit Bot
Comment 6 2013-09-09 15:17:19 PDT
Comment on attachment 211081 [details] Patch Clearing flags on attachment: 211081 Committed r155391: <http://trac.webkit.org/changeset/155391>
WebKit Commit Bot
Comment 7 2013-09-09 15:17:22 PDT
All reviewed patches have been landed. Closing bug.
Note You need to log in before you can comment on or make changes to this bug.