Bug 120764

Summary: [Win][WebGL] Crash on exit
Product: WebKit Reporter: peavo
Component: WebGLAssignee: Nobody <webkit-unassigned>
Status: RESOLVED FIXED    
Severity: Normal CC: achristensen, bfulgham, commit-queue, mrobinson
Priority: P2 Keywords: PlatformOnly
Version: 528+ (Nightly build)   
Hardware: PC   
OS: Unspecified   
URL: http://media.tojicode.com/q3bsp/
Attachments:
Description Flags
Patch
none
Patch none

peavo
Reported 2013-09-05 03:58:05 PDT
Everytime I have visited a page with WebGL content, I get a crash on exit (NULL pointer access violation). I believe the reason for the crash is that the libGLESv2.dll is detached from the process at exit, and releases relevant memory, and then the atexit cleanup routine is called afterwards, accessing the released memory. This is the stacktrace I'm getting: libGLESv2.dll!0588787f() [Frames below may be incorrect and/or missing, no symbols loaded for libGLESv2.dll] libGLESv2.dll!05893fdc() WebKit.dll!WebCore::GLContextEGL::~GLContextEGL() Line 236 C++ WebKit.dll!WebCore::GLContextEGL::`scalar deleting destructor'() + 0xb bytes C++ WebKit.dll!WebCore::GLContext::cleanupActiveContextsAtExit() Line 140 C++ WebKit.dll!_CRT_INIT(void * hDllHandle, unsigned long dwReason, void * lpreserved) Line 415 C WebKit.dll!__DllMainCRTStartup(void * hDllHandle, unsigned long dwReason, void * lpreserved) Line 526 + 0x8 bytes C WebKit.dll!_DllMainCRTStartup(void * hDllHandle, unsigned long dwReason, void * lpreserved) Line 476 + 0xe bytes C
Attachments
Patch (1.58 KB, patch)
2013-09-05 04:09 PDT, peavo 		no flags
DetailsFormatted DiffDiff
Patch (2.54 KB, patch)
2013-10-04 06:13 PDT, peavo 		no flags
DetailsFormatted DiffDiff
Show Obsolete (1) View All Add attachment proposed patch, testcase, etc.
peavo
Comment 1 2013-09-05 04:09:08 PDT
Created attachment 210598 [details] Patch
Martin Robinson
Comment 2 2013-10-03 14:14:02 PDT
Nice catch. This can probably be surrounded by PLATFORM(X11) actually. Looks like the activeContextList is unused otherwise? That can go into the #ifdef as well, i guess.
peavo
Comment 3 2013-10-04 06:13:33 PDT
Created attachment 213356 [details] Patch
peavo
Comment 4 2013-10-04 06:14:55 PDT
(In reply to comment #2) > Nice catch. This can probably be surrounded by PLATFORM(X11) actually. Looks like the activeContextList is unused otherwise? That can go into the #ifdef as well, i guess. Thanks for looking into this, I have updated the patch accordingly :) This should also reduce code size for other platforms.
Martin Robinson
Comment 5 2013-10-04 09:10:44 PDT
Comment on attachment 213356 [details] Patch Thanks!
WebKit Commit Bot
Comment 6 2013-10-04 09:14:14 PDT
Comment on attachment 213356 [details] Patch Clearing flags on attachment: 213356 Committed r156893: <http://trac.webkit.org/changeset/156893>
WebKit Commit Bot
Comment 7 2013-10-04 09:14:16 PDT
All reviewed patches have been landed. Closing bug.
peavo
Comment 8 2013-10-04 09:51:13 PDT
(In reply to comment #5) > (From update of attachment 213356 [details]) > Thanks! Thanks for reviewing ;)
Note You need to log in before you can comment on or make changes to this bug.