Bug 120703

Summary: [GTK] MediaControlsGtk: fix warning in constructor due to incorrect order of attributes
Product: WebKit Reporter: Alberto Garcia <berto>
Component: WebCore Misc.Assignee: Alberto Garcia <berto>
Status: RESOLVED FIXED    
Severity: Normal CC: commit-queue, eric.carlson, esprehn+autocc, glenn, jer.noble, mrobinson
Priority: P2    
Version: 528+ (Nightly build)   
Hardware: Unspecified   
OS: Unspecified   
Attachments:
Description Flags
Patch cgarcia: review+

Description Alberto Garcia 2013-09-04 15:04:12 PDT
CXX      Source/WebCore/rendering/libWebCore_la-RenderTextFragment.lo
In file included from ../../Source/WebCore/html/shadow/MediaControlsGtk.cpp:32:0:
../../Source/WebCore/html/shadow/MediaControlsGtk.h: In constructor 'WebCore::MediaControlsGtk::MediaControlsGtk(WebCore::Document*)':
../../Source/WebCore/html/shadow/MediaControlsGtk.h:76:43: warning: 'WebCore::MediaControlsGtk::m_eventListener' will be initialized after [-Wreorder]
../../Source/WebCore/html/shadow/MediaControlsGtk.h:73:49: warning:   'WebCore::MediaControlClosedCaptionsTrackListElement* WebCore::MediaControlsGtk::m_closedCaptionsTrackList' [-Wreorder]
../../Source/WebCore/html/shadow/MediaControlsGtk.cpp:63:1: warning:   when initialized here [-Wreorder]

In this case it's harmless since all those elements are initialized to 0.
Comment 1 Alberto Garcia 2013-09-04 15:06:22 PDT
Created attachment 210500 [details]
Patch
Comment 2 Alberto Garcia 2013-09-05 00:21:05 PDT
Committed r155102: <http://trac.webkit.org/changeset/155102>