Bug 120653

Summary: REGRESSION (r154967) window resize is very choppy
Product: WebKit Reporter: Simon Fraser (smfr) <simon.fraser>
Component: WebKit2Assignee: Darin Adler <darin>
Severity: Normal CC: ap, commit-queue, darin, kling, simon.fraser
Priority: P2    
Version: 528+ (Nightly build)   
Hardware: All   
OS: All   
Description Flags
Patch none

Description Simon Fraser (smfr) 2013-09-03 15:36:23 PDT
Window resize with a very simple no-JS testcase is terrible after r154967.

People say that tab switching is also impacted.
Comment 1 Darin Adler 2013-09-03 16:09:56 PDT
If the symptom is that bad, maybe we should just roll out!

I assume I just got one of the conditions backwards in the patch somewhere, or removed an early return I should not have.
Comment 2 Alexey Proskuryakov 2013-09-03 16:32:21 PDT
If rolling out, r154981 should be rolled out too.
Comment 3 Darin Adler 2013-09-03 19:03:32 PDT
Is this in release builds, or only debug builds?
Comment 4 Darin Adler 2013-09-03 19:04:40 PDT
I tried to find things I did wrong in the patch, especially ones that could possibly have anything to do with window resizing.

So far, all I found was bug 120659.
Comment 5 Darin Adler 2013-09-03 20:16:23 PDT
*** Bug 120660 has been marked as a duplicate of this bug. ***
Comment 6 Darin Adler 2013-09-03 20:18:08 PDT
Created attachment 210424 [details]
Comment 7 WebKit Commit Bot 2013-09-03 20:19:26 PDT
Attachment 210424 [details] did not pass style-queue:

Failed to run "['Tools/Scripts/check-webkit-style', '--diff-files', u'Source/WebKit2/ChangeLog', u'Source/WebKit2/Platform/CoreIPC/Connection.cpp']" exit_code: 1
Source/WebKit2/Platform/CoreIPC/Connection.cpp:420:  Missing spaces around >>  [whitespace/operators] [3]
Total errors found: 1 in 2 files

If any of these errors are false positives, please file a bug against check-webkit-style.
Comment 8 Andreas Kling 2013-09-03 20:19:41 PDT
Comment on attachment 210424 [details]

View in context: https://bugs.webkit.org/attachment.cgi?id=210424&action=review

> Source/WebKit2/Platform/CoreIPC/Connection.cpp:420
> +        HashMap<std::pair<std::pair<StringReference, StringReference>, uint64_t>, OwnPtr<MessageDecoder>>::iterator it = m_waitForMessageMap.find(messageAndDestination);

No auto? ;-)
Comment 9 WebKit Commit Bot 2013-09-03 21:26:56 PDT
Comment on attachment 210424 [details]

Clearing flags on attachment: 210424

Committed r155017: <http://trac.webkit.org/changeset/155017>
Comment 10 WebKit Commit Bot 2013-09-03 21:26:59 PDT
All reviewed patches have been landed.  Closing bug.