Bug 120653 – REGRESSION (r154967) window resize is very choppy

• Component: WebKit2
• Status: RESOLVED FIXED

[Simon Fraser (smfr)]

Window resize with a very simple no-JS testcase is terrible after r154967.

People say that tab switching is also impacted.

[Darin Adler]

If the symptom is that bad, maybe we should just roll out!

I assume I just got one of the conditions backwards in the patch somewhere, or removed an early return I should not have.

[Alexey Proskuryakov]

If rolling out, r154981 should be rolled out too.

[Darin Adler]

Is this in release builds, or only debug builds?

[Darin Adler]

I tried to find things I did wrong in the patch, especially ones that could possibly have anything to do with window resizing.

So far, all I found was bug 120659.

[Darin Adler]

*** Bug 120660 has been marked as a duplicate of this bug. ***

[Darin Adler]

Created attachment 210424 [details]
Patch

[WebKit Commit Bot]

Attachment 210424 [details] did not pass style-queue:

Failed to run "['Tools/Scripts/check-webkit-style', '--diff-files', u'Source/WebKit2/ChangeLog', u'Source/WebKit2/Platform/CoreIPC/Connection.cpp']" exit_code: 1
Source/WebKit2/Platform/CoreIPC/Connection.cpp:420:  Missing spaces around >>  [whitespace/operators] [3]
Total errors found: 1 in 2 files


If any of these errors are false positives, please file a bug against check-webkit-style.

[Andreas Kling]

Comment on attachment 210424 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=210424&action=review

> Source/WebKit2/Platform/CoreIPC/Connection.cpp:420
> +        HashMap<std::pair<std::pair<StringReference, StringReference>, uint64_t>, OwnPtr<MessageDecoder>>::iterator it = m_waitForMessageMap.find(messageAndDestination);

No auto? ;-)

[WebKit Commit Bot]

Comment on attachment 210424 [details]
Patch

Clearing flags on attachment: 210424

Committed r155017: <http://trac.webkit.org/changeset/155017>

[WebKit Commit Bot]

All reviewed patches have been landed.  Closing bug.