Bug 120641

Summary: [Mac] Hyphenation respects regional format settings language instead of primary language
Product: WebKit Reporter: Alexey Proskuryakov <ap>
Component: TextAssignee: Alexey Proskuryakov <ap>
Status: RESOLVED FIXED    
Severity: Normal CC: mitz
Priority: P2    
Version: 528+ (Nightly build)   
Hardware: Unspecified   
OS: Unspecified   
Attachments:
Description Flags
proposed fix mitz: review+

Alexey Proskuryakov
Reported 2013-09-03 10:54:39 PDT
Hyphenation is about language and not regional format. This makes some hyphenation tests fail for me locally because DumpRenderTree and WebKitTestRunner override AppleLanguages user default, but not AppleLocale one, and my locale language is not supported for hyphenation. See also <rdar://problem/14897664>.
Attachments
proposed fix (56.80 KB, patch)
2013-09-03 10:58 PDT, Alexey Proskuryakov 		mitz: review+
DetailsFormatted DiffDiff
View All Add attachment proposed patch, testcase, etc.
Alexey Proskuryakov
Comment 1 2013-09-03 10:58:39 PDT
Created attachment 210389 [details] proposed fix
mitz
Comment 2 2013-09-03 11:04:10 PDT
Comment on attachment 210389 [details] proposed fix View in context: https://bugs.webkit.org/attachment.cgi?id=210389&action=review > Source/WebCore/platform/text/cf/HyphenationCF.cpp:40 > + // Fall back to a locale created from user's default language (respecting testing overrides). I don’t think the parenthetical is helpful. > LayoutTests/ChangeLog:9 > + expected pixel results in mac-lion dorectory. Typo: dorectory
Alexey Proskuryakov
Comment 3 2013-09-03 12:00:05 PDT
Committed <http://trac.webkit.org/changeset/154995>.
Note You need to log in before you can comment on or make changes to this bug.