Bug 120637 – Support Vector<Ref<T>>.

• Component: Web Template Framework
• Status: RESOLVED FIXED

[Andreas Kling]

Support Vector<Ref<T>>.

[Andreas Kling]

Created attachment 210379 [details]
Will EWS blend it?

[EFL EWS Bot]

Comment on attachment 210379 [details]
Will EWS blend it?

Attachment 210379 [details] did not pass efl-wk2-ews (efl-wk2):
Output: http://webkit-queues.appspot.com/results/1691288

[EFL EWS Bot]

Comment on attachment 210379 [details]
Will EWS blend it?

Attachment 210379 [details] did not pass efl-ews (efl):
Output: http://webkit-queues.appspot.com/results/1696123

[Andreas Kling]

Created attachment 210394 [details]
Patch

[Antti Koivisto]

Comment on attachment 210394 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=210394&action=review

ok

> Source/WebCore/page/Page.cpp:1201
> +
> +    return views;
>  }

With our current vector implementation do we avoid doing vector copy here?

> Source/WebCore/page/Page.cpp:1210
> +    auto views = pluginViews();

It is bit non-obvious what the return type is. Would something like pluginViewsAsVector be helpful?

[Andreas Kling]

(In reply to comment #5)
> (From update of attachment 210394 [details])
> View in context: https://bugs.webkit.org/attachment.cgi?id=210394&action=review
> 
> ok
> 
> > Source/WebCore/page/Page.cpp:1201
> > +
> > +    return views;
> >  }
> 
> With our current vector implementation do we avoid doing vector copy here?

Yep, according to Anders who added a move constructor to Vector.

[WebKit Commit Bot]

Comment on attachment 210394 [details]
Patch

Clearing flags on attachment: 210394

Committed r154997: <http://trac.webkit.org/changeset/154997>

[WebKit Commit Bot]

All reviewed patches have been landed.  Closing bug.

[Mikhail Pozdnyakov]

Comment on attachment 210394 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=210394&action=review

> Source/WTF/wtf/Ref.h:36
> +    Ref(const T& object) : m_ptr(&const_cast<T&>(object)) { m_ptr->ref(); }

Having only "Ref(T& object)" ctor hado enforced that Ref class can be produced only from non-temporary object. Now Ref can be produced from temporaries, is it desired behaviour?

[Mikhail Pozdnyakov]

Comment on attachment 210394 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=210394&action=review

> Source/WTF/ChangeLog:12
> +        think of a good name for that, and it'd be nice if append() would "just work."

how about overloaded append() accepting non const reference?