Bug 120597

Summary:	[Qt] New fast/events tests are failing after r154673.
Product:	WebKit	Reporter:	Ádám Kallai <kadam>
Component:	Tools / Tests	Assignee:	Nobody <webkit-unassigned>
Status:	RESOLVED INVALID
Severity:	Normal	CC:	abrhm, allan.jensen, cdumez, ossy, zarvai
Priority:	P2
Version:	528+ (Nightly build)
Hardware:	Unspecified
OS:	Unspecified
Bug Depends on:	94081
Bug Blocks:	87008

Description Ádám Kallai 2013-09-02 02:42:30 PDT

* fast/events/wheelevent-basic.html
Wk2 result:
http://build.webkit.sed.hu/results/x86-32%20Linux%20Qt%20Release%20WebKit2/r154949%20(37810)/fast/events/wheelevent-basic-pretty-diff.html

Wk1 result: is it correct results?
http://build.webkit.sed.hu/results/x86-32%20Linux%20Qt%20Release%20NRWT/r154949%20(36446)/fast/events/wheelevent-basic-pretty-diff.html

* fast/events/wheelevent-constructor.html
http://build.webkit.sed.hu/results/x86-32%20Linux%20Qt%20Release%20WebKit2/r154949%20(37810)/fast/events/wheelevent-constructor-pretty-diff.html

This test fails only Qt Wk2 bot.
* fast/events/wheelevent-mousewheel-interaction.html
http://build.webkit.sed.hu/results/x86-32%20Linux%20Qt%20Release%20WebKit2/r154949%20(37810)/fast/events/wheelevent-mousewheel-interaction-pretty-diff.html

Could you check what happened to it?

Comment 1 Chris Dumez 2013-09-02 03:07:37 PDT

> Wk1 result: is it correct results?
> http://build.webkit.sed.hu/results/x86-32%20Linux%20Qt%20Release%20NRWT/r154949%20(36446)/fast/events/wheelevent-basic-pretty-diff.html

This one is OK and only needs a platform specific baseline. Some platforms issue 2 wheel events instead of 1 when scrolling both horizontally and vertically. 

The others look like proper failures. It looks like it fails to construct a WheelEvent. Is it possible that the Qt port has DOM4_EVENTS_CONSTRUCTOR flag disabled at compile time? If so, this is the reason and you may consider enabling it.

Comment 2 Csaba Osztrogonác 2013-09-02 03:26:15 PDT

There is a line in platform/qt/TestExpectations:
# ENABLE(DOM4_EVENTS_CONSTRUCTOR) is disabled.

So it seems these tests should be skipped to or 
DOM4_EVENTS_CONSTRUCTOR should be enabled by default.

Comment 3 Chris Dumez 2013-09-02 03:38:07 PDT

(In reply to comment #2)
> There is a line in platform/qt/TestExpectations:
> # ENABLE(DOM4_EVENTS_CONSTRUCTOR) is disabled.
> 
> So it seems these tests should be skipped to or 
> DOM4_EVENTS_CONSTRUCTOR should be enabled by default.

DOM4 event constructors are much nicer than the alternative and are becoming more and more popular (legacy init functions are deprecated in DOM4). Safari, Chrome and Firefox all support DOM4 event constructors.

I suggest you enable them but up to you.

Comment 4 Csaba Osztrogonác 2013-09-02 03:40:47 PDT

(In reply to comment #3)
> (In reply to comment #2)
> > There is a line in platform/qt/TestExpectations:
> > # ENABLE(DOM4_EVENTS_CONSTRUCTOR) is disabled.
> > 
> > So it seems these tests should be skipped to or 
> > DOM4_EVENTS_CONSTRUCTOR should be enabled by default.
> 
> DOM4 event constructors are much nicer than the alternative and are becoming more and more popular (legacy init functions are deprecated in DOM4). Safari, Chrome and Firefox all support DOM4 event constructors.
> 
> I suggest you enable them but up to you.

not me, but Qt maintainers. :) Allan?

Comment 5 Jocelyn Turcotte 2014-02-03 03:27:00 PST

=== Bulk closing of Qt bugs ===

If you believe that this bug report is still relevant for a non-Qt port of webkit.org, please re-open it and remove [Qt] from the summary.

If you believe that this is still an important QtWebKit bug, please fill a new report at https://bugreports.qt-project.org and add a link to this issue. See http://qt-project.org/wiki/ReportingBugsInQt for additional guidelines.