| Summary: | EditCommand constructors should take Document&. | ||||||||
|---|---|---|---|---|---|---|---|---|---|
| Product: | WebKit | Reporter: | Andreas Kling <kling> | ||||||
| Component: | HTML Editing | Assignee: | Andreas Kling <kling> | ||||||
| Status: | RESOLVED FIXED | ||||||||
| Severity: | Normal | CC: | commit-queue, kling, sam | ||||||
| Priority: | P2 | ||||||||
| Version: | 528+ (Nightly build) | ||||||||
| Hardware: | Unspecified | ||||||||
| OS: | Unspecified | ||||||||
| Attachments: |
|
||||||||
|
Description
Andreas Kling
2013-08-31 14:31:19 PDT
Created attachment 210214 [details]
EWS thing
Attachment 210214 [details] did not pass style-queue:
Failed to run "['Tools/Scripts/check-webkit-style', '--diff-files', u'Source/WebCore/editing/AppendNodeCommand.cpp', u'Source/WebCore/editing/ApplyBlockElementCommand.cpp', u'Source/WebCore/editing/ApplyBlockElementCommand.h', u'Source/WebCore/editing/ApplyStyleCommand.cpp', u'Source/WebCore/editing/ApplyStyleCommand.h', u'Source/WebCore/editing/BreakBlockquoteCommand.cpp', u'Source/WebCore/editing/BreakBlockquoteCommand.h', u'Source/WebCore/editing/CompositeEditCommand.cpp', u'Source/WebCore/editing/CompositeEditCommand.h', u'Source/WebCore/editing/CreateLinkCommand.cpp', u'Source/WebCore/editing/CreateLinkCommand.h', u'Source/WebCore/editing/DeleteButtonController.cpp', u'Source/WebCore/editing/DeleteFromTextNodeCommand.cpp', u'Source/WebCore/editing/DeleteSelectionCommand.cpp', u'Source/WebCore/editing/DeleteSelectionCommand.h', u'Source/WebCore/editing/DictationCommand.cpp', u'Source/WebCore/editing/DictationCommand.h', u'Source/WebCore/editing/EditCommand.cpp', u'Source/WebCore/editing/EditCommand.h', u'Source/WebCore/editing/EditingStyle.cpp', u'Source/WebCore/editing/EditingStyle.h', u'Source/WebCore/editing/Editor.cpp', u'Source/WebCore/editing/Editor.h', u'Source/WebCore/editing/EditorCommand.cpp', u'Source/WebCore/editing/FormatBlockCommand.cpp', u'Source/WebCore/editing/FormatBlockCommand.h', u'Source/WebCore/editing/IndentOutdentCommand.cpp', u'Source/WebCore/editing/IndentOutdentCommand.h', u'Source/WebCore/editing/InsertIntoTextNodeCommand.cpp', u'Source/WebCore/editing/InsertLineBreakCommand.cpp', u'Source/WebCore/editing/InsertLineBreakCommand.h', u'Source/WebCore/editing/InsertListCommand.cpp', u'Source/WebCore/editing/InsertListCommand.h', u'Source/WebCore/editing/InsertNodeBeforeCommand.cpp', u'Source/WebCore/editing/InsertParagraphSeparatorCommand.cpp', u'Source/WebCore/editing/InsertParagraphSeparatorCommand.h', u'Source/WebCore/editing/InsertTextCommand.cpp', u'Source/WebCore/editing/InsertTextCommand.h', u'Source/WebCore/editing/MergeIdenticalElementsCommand.cpp', u'Source/WebCore/editing/ModifySelectionListLevel.cpp', u'Source/WebCore/editing/ModifySelectionListLevel.h', u'Source/WebCore/editing/MoveSelectionCommand.cpp', u'Source/WebCore/editing/RemoveCSSPropertyCommand.cpp', u'Source/WebCore/editing/RemoveCSSPropertyCommand.h', u'Source/WebCore/editing/RemoveFormatCommand.cpp', u'Source/WebCore/editing/RemoveFormatCommand.h', u'Source/WebCore/editing/RemoveNodeCommand.cpp', u'Source/WebCore/editing/RemoveNodePreservingChildrenCommand.cpp', u'Source/WebCore/editing/ReplaceNodeWithSpanCommand.cpp', u'Source/WebCore/editing/ReplaceSelectionCommand.cpp', u'Source/WebCore/editing/ReplaceSelectionCommand.h', u'Source/WebCore/editing/SetNodeAttributeCommand.cpp', u'Source/WebCore/editing/SetSelectionCommand.cpp', u'Source/WebCore/editing/SimplifyMarkupCommand.cpp', u'Source/WebCore/editing/SimplifyMarkupCommand.h', u'Source/WebCore/editing/SpellingCorrectionCommand.cpp', u'Source/WebCore/editing/SplitElementCommand.cpp', u'Source/WebCore/editing/SplitTextNodeCommand.cpp', u'Source/WebCore/editing/SplitTextNodeContainingElementCommand.cpp', u'Source/WebCore/editing/TextInsertionBaseCommand.cpp', u'Source/WebCore/editing/TextInsertionBaseCommand.h', u'Source/WebCore/editing/TypingCommand.cpp', u'Source/WebCore/editing/TypingCommand.h', u'Source/WebCore/editing/UnlinkCommand.cpp', u'Source/WebCore/editing/UnlinkCommand.h', u'Source/WebCore/editing/WrapContentsInDummySpanCommand.cpp', u'Source/WebCore/page/ContextMenuController.cpp', u'Source/WebCore/page/DragController.cpp']" exit_code: 1
Source/WebCore/editing/RemoveCSSPropertyCommand.h:44: The parameter name "property" adds no information, so it should be removed. [readability/parameter_name] [5]
Total errors found: 1 in 68 files
If any of these errors are false positives, please file a bug against check-webkit-style.
Created attachment 210217 [details]
Patchy patch
Comment on attachment 210217 [details] Patchy patch Clearing flags on attachment: 210217 Committed r154938: <http://trac.webkit.org/changeset/154938> All reviewed patches have been landed. Closing bug. |