Bug 120565

Summary:

Make more use of toRenderFoo(RenderObject&) cast helpers.

Product:

WebKit

Reporter:

Andreas Kling <kling>

Component:

Layout and Rendering

Assignee:

Andreas Kling <kling>

Status:

RESOLVED FIXED

Severity:

Normal

CC:

aboxhall, apinheiro, cfleizach, commit-queue, dmazzoni, d-r, eflews.bot, eric.carlson, esprehn+autocc, fmalita, glenn, gtk-ews, gyuyoung.kim, japhet, jdiggs, jer.noble, kondapallykalyan, mario, pdr, schenney, simon.fraser, WebkitBugTracker, xan.lopez

Priority:

Version:

528+ (Nightly build)

Hardware:

Unspecified

OS:

Unspecified

Attachments:

Description	Flags
Patch idea	eflews.bot: commit-queue-
Patch	eflews.bot: commit-queue-
Patch	none

Andreas Kling

Reported 2013-08-31 13:20:09 PDT

Make more use of toRenderFoo(RenderObject&) cast helpers.

Attachments
Patch idea (84.51 KB, patch) 2013-08-31 13:21 PDT, Andreas Kling	eflews.bot: commit-queue-	Details Formatted Diff Diff
Patch (84.54 KB, patch) 2013-08-31 13:28 PDT, Andreas Kling	eflews.bot: commit-queue-	Details Formatted Diff Diff
Patch (87.11 KB, patch) 2013-08-31 14:40 PDT, Andreas Kling	no flags	Details Formatted Diff Diff
Show Obsolete (2) View All Add attachment proposed patch, testcase, etc.

Andreas Kling

Comment 1 2013-08-31 13:21:53 PDT

Created attachment 210210 [details] Patch idea

WebKit Commit Bot

Comment 2 2013-08-31 13:24:22 PDT

Attachment 210210 [details] did not pass style-queue: Failed to run "['Tools/Scripts/check-webkit-style', '--diff-files', u'Source/WebCore/ChangeLog', u'Source/WebCore/accessibility/AccessibilityRenderObject.cpp', u'Source/WebCore/html/HTMLMediaElement.cpp', u'Source/WebCore/html/shadow/MediaControlElements.cpp', u'Source/WebCore/loader/ImageLoader.cpp', u'Source/WebCore/page/FrameView.cpp', u'Source/WebCore/rendering/InlineBox.h', u'Source/WebCore/rendering/InlineFlowBox.cpp', u'Source/WebCore/rendering/InlineTextBox.cpp', u'Source/WebCore/rendering/InlineTextBox.h', u'Source/WebCore/rendering/RenderBR.h', u'Source/WebCore/rendering/RenderBlock.cpp', u'Source/WebCore/rendering/RenderBlock.h', u'Source/WebCore/rendering/RenderBlockLineLayout.cpp', u'Source/WebCore/rendering/RenderBox.cpp', u'Source/WebCore/rendering/RenderBox.h', u'Source/WebCore/rendering/RenderBoxModelObject.cpp', u'Source/WebCore/rendering/RenderBoxModelObject.h', u'Source/WebCore/rendering/RenderCombineText.h', u'Source/WebCore/rendering/RenderFlowThread.cpp', u'Source/WebCore/rendering/RenderFlowThread.h', u'Source/WebCore/rendering/RenderImage.h', u'Source/WebCore/rendering/RenderInline.h', u'Source/WebCore/rendering/RenderLayer.cpp', u'Source/WebCore/rendering/RenderLayer.h', u'Source/WebCore/rendering/RenderLayerBacking.cpp', u'Source/WebCore/rendering/RenderLayerCompositor.cpp', u'Source/WebCore/rendering/RenderLayerCompositor.h', u'Source/WebCore/rendering/RenderListMarker.h', u'Source/WebCore/rendering/RenderObject.cpp', u'Source/WebCore/rendering/RenderRubyBase.cpp', u'Source/WebCore/rendering/RenderRubyRun.h', u'Source/WebCore/rendering/RenderText.cpp', u'Source/WebCore/rendering/RenderText.h', u'Source/WebCore/rendering/RenderTreeAsText.cpp', u'Source/WebCore/rendering/RenderVideo.h', u'Source/WebCore/rendering/RenderView.h', u'Source/WebCore/rendering/svg/RenderSVGInlineText.h', u'Source/WebCore/rendering/svg/RenderSVGText.cpp']" exit_code: 1 Source/WebCore/rendering/InlineFlowBox.cpp:170: Weird number of spaces at line-start. Are you using a 4-space indent? [whitespace/indent] [3] Source/WebCore/rendering/InlineFlowBox.cpp:668: Weird number of spaces at line-start. Are you using a 4-space indent? [whitespace/indent] [3] Total errors found: 2 in 39 files If any of these errors are false positives, please file a bug against check-webkit-style.

EFL EWS Bot

Comment 3 2013-08-31 13:28:33 PDT

Comment on attachment 210210 [details] Patch idea Attachment 210210 [details] did not pass efl-wk2-ews (efl-wk2): Output: http://webkit-queues.appspot.com/results/1679204

Andreas Kling

Comment 4 2013-08-31 13:28:48 PDT

Created attachment 210211 [details] Patch

WebKit Commit Bot

Comment 5 2013-08-31 13:31:48 PDT

Attachment 210211 [details] did not pass style-queue: Failed to run "['Tools/Scripts/check-webkit-style', '--diff-files', u'Source/WebCore/ChangeLog', u'Source/WebCore/accessibility/AccessibilityRenderObject.cpp', u'Source/WebCore/html/HTMLMediaElement.cpp', u'Source/WebCore/html/shadow/MediaControlElements.cpp', u'Source/WebCore/loader/ImageLoader.cpp', u'Source/WebCore/page/FrameView.cpp', u'Source/WebCore/rendering/InlineBox.h', u'Source/WebCore/rendering/InlineFlowBox.cpp', u'Source/WebCore/rendering/InlineTextBox.cpp', u'Source/WebCore/rendering/InlineTextBox.h', u'Source/WebCore/rendering/RenderBR.h', u'Source/WebCore/rendering/RenderBlock.cpp', u'Source/WebCore/rendering/RenderBlock.h', u'Source/WebCore/rendering/RenderBlockLineLayout.cpp', u'Source/WebCore/rendering/RenderBox.cpp', u'Source/WebCore/rendering/RenderBox.h', u'Source/WebCore/rendering/RenderBoxModelObject.cpp', u'Source/WebCore/rendering/RenderBoxModelObject.h', u'Source/WebCore/rendering/RenderCombineText.h', u'Source/WebCore/rendering/RenderFlowThread.cpp', u'Source/WebCore/rendering/RenderFlowThread.h', u'Source/WebCore/rendering/RenderImage.h', u'Source/WebCore/rendering/RenderInline.h', u'Source/WebCore/rendering/RenderLayer.cpp', u'Source/WebCore/rendering/RenderLayer.h', u'Source/WebCore/rendering/RenderLayerBacking.cpp', u'Source/WebCore/rendering/RenderLayerCompositor.cpp', u'Source/WebCore/rendering/RenderLayerCompositor.h', u'Source/WebCore/rendering/RenderListMarker.h', u'Source/WebCore/rendering/RenderObject.cpp', u'Source/WebCore/rendering/RenderRubyBase.cpp', u'Source/WebCore/rendering/RenderRubyRun.h', u'Source/WebCore/rendering/RenderText.cpp', u'Source/WebCore/rendering/RenderText.h', u'Source/WebCore/rendering/RenderTreeAsText.cpp', u'Source/WebCore/rendering/RenderVideo.h', u'Source/WebCore/rendering/RenderView.h', u'Source/WebCore/rendering/svg/RenderSVGInlineText.h', u'Source/WebCore/rendering/svg/RenderSVGText.cpp']" exit_code: 1 Source/WebCore/rendering/InlineFlowBox.cpp:170: Weird number of spaces at line-start. Are you using a 4-space indent? [whitespace/indent] [3] Source/WebCore/rendering/InlineFlowBox.cpp:668: Weird number of spaces at line-start. Are you using a 4-space indent? [whitespace/indent] [3] Total errors found: 2 in 39 files If any of these errors are false positives, please file a bug against check-webkit-style.

EFL EWS Bot

Comment 6 2013-08-31 13:39:44 PDT

Comment on attachment 210211 [details] Patch Attachment 210211 [details] did not pass efl-wk2-ews (efl-wk2): Output: http://webkit-queues.appspot.com/results/1661416

EFL EWS Bot

Comment 7 2013-08-31 13:56:55 PDT

Comment on attachment 210211 [details] Patch Attachment 210211 [details] did not pass efl-ews (efl): Output: http://webkit-queues.appspot.com/results/1641437

kov's GTK+ EWS bot

Comment 8 2013-08-31 14:19:11 PDT

Comment on attachment 210211 [details] Patch Attachment 210211 [details] did not pass gtk-ews (gtk): Output: http://webkit-queues.appspot.com/results/1664433

Andreas Kling

Comment 9 2013-08-31 14:40:35 PDT

Created attachment 210215 [details] Patch

WebKit Commit Bot

Comment 10 2013-08-31 14:42:27 PDT

Attachment 210215 [details] did not pass style-queue: Failed to run "['Tools/Scripts/check-webkit-style', '--diff-files', u'Source/WebCore/ChangeLog', u'Source/WebCore/accessibility/AccessibilityRenderObject.cpp', u'Source/WebCore/accessibility/atk/AccessibilityObjectAtk.cpp', u'Source/WebCore/accessibility/atk/WebKitAccessibleHyperlink.cpp', u'Source/WebCore/accessibility/atk/WebKitAccessibleInterfaceText.cpp', u'Source/WebCore/html/HTMLMediaElement.cpp', u'Source/WebCore/html/shadow/MediaControlElements.cpp', u'Source/WebCore/loader/ImageLoader.cpp', u'Source/WebCore/page/FrameView.cpp', u'Source/WebCore/rendering/InlineBox.h', u'Source/WebCore/rendering/InlineFlowBox.cpp', u'Source/WebCore/rendering/InlineTextBox.cpp', u'Source/WebCore/rendering/InlineTextBox.h', u'Source/WebCore/rendering/RenderBR.h', u'Source/WebCore/rendering/RenderBlock.cpp', u'Source/WebCore/rendering/RenderBlock.h', u'Source/WebCore/rendering/RenderBlockLineLayout.cpp', u'Source/WebCore/rendering/RenderBox.cpp', u'Source/WebCore/rendering/RenderBox.h', u'Source/WebCore/rendering/RenderBoxModelObject.cpp', u'Source/WebCore/rendering/RenderBoxModelObject.h', u'Source/WebCore/rendering/RenderCombineText.h', u'Source/WebCore/rendering/RenderFlowThread.cpp', u'Source/WebCore/rendering/RenderFlowThread.h', u'Source/WebCore/rendering/RenderImage.h', u'Source/WebCore/rendering/RenderInline.h', u'Source/WebCore/rendering/RenderLayer.cpp', u'Source/WebCore/rendering/RenderLayer.h', u'Source/WebCore/rendering/RenderLayerBacking.cpp', u'Source/WebCore/rendering/RenderLayerCompositor.cpp', u'Source/WebCore/rendering/RenderLayerCompositor.h', u'Source/WebCore/rendering/RenderListMarker.h', u'Source/WebCore/rendering/RenderObject.cpp', u'Source/WebCore/rendering/RenderRubyBase.cpp', u'Source/WebCore/rendering/RenderRubyRun.h', u'Source/WebCore/rendering/RenderText.cpp', u'Source/WebCore/rendering/RenderText.h', u'Source/WebCore/rendering/RenderTreeAsText.cpp', u'Source/WebCore/rendering/RenderVideo.h', u'Source/WebCore/rendering/RenderView.h', u'Source/WebCore/rendering/svg/RenderSVGInlineText.h', u'Source/WebCore/rendering/svg/RenderSVGText.cpp']" exit_code: 1 Source/WebCore/rendering/InlineFlowBox.cpp:170: Weird number of spaces at line-start. Are you using a 4-space indent? [whitespace/indent] [3] Total errors found: 1 in 42 files If any of these errors are false positives, please file a bug against check-webkit-style.

Darin Adler

Comment 11 2013-08-31 21:42:35 PDT

Comment on attachment 210215 [details] Patch These all look pretty good.

WebKit Commit Bot

Comment 12 2013-08-31 22:28:00 PDT

Comment on attachment 210215 [details] Patch Clearing flags on attachment: 210215 Committed r154937: <http://trac.webkit.org/changeset/154937>

WebKit Commit Bot

Comment 13 2013-08-31 22:28:04 PDT

All reviewed patches have been landed. Closing bug.

Note You need to log in before you can comment on or make changes to this bug.