Bug 120558

Summary: Don't do document style recalc unless there's a RenderView.
Product: WebKit Reporter: Andreas Kling <kling>
Component: Layout and RenderingAssignee: Andreas Kling <kling>
Status: RESOLVED FIXED    
Severity: Normal CC: commit-queue, esprehn+autocc, kangil.han
Priority: P2    
Version: 528+ (Nightly build)   
Hardware: Unspecified   
OS: Unspecified   
Attachments:
Description Flags
Patch
koivisto: review-
Patch 2
koivisto: review+
P4L none

Description Andreas Kling 2013-08-31 06:10:18 PDT 
Don't do document style recalc unless there's a RenderView.
Comment 1 Andreas Kling 2013-08-31 06:18:58 PDT 
Created attachment 210186 [details]
Patch
Comment 2 Antti Koivisto 2013-08-31 06:21:44 PDT 
Comment on attachment 210186 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=210186&action=review

Looks generally good.

> Source/WebCore/dom/Document.cpp:-1738
> -    ASSERT(!view() || !view()->isPainting());

Please don't remove the painting assert. It is valuable!
Comment 3 Andreas Kling 2013-08-31 06:26:48 PDT 
Created attachment 210188 [details]
Patch 2
Comment 4 Andreas Kling 2013-08-31 06:36:01 PDT 
Created attachment 210189 [details]
P4L
Comment 5 WebKit Commit Bot 2013-08-31 07:07:18 PDT 
Comment on attachment 210189 [details]
P4L

Clearing flags on attachment: 210189

Committed r154927: <http://trac.webkit.org/changeset/154927>
Comment 6 WebKit Commit Bot 2013-08-31 07:07:20 PDT 
All reviewed patches have been landed.  Closing bug.