Bug 120543 – warning: unused parameter ‘renderingMode' in ImageBufferCairo.cpp:94

• Component: WebKit Misc.
• Status: RESOLVED FIXED

[Santosh Mahto]

‘renderingMode' should be guarded with UNUSED_PARAM()

[Santosh Mahto]

Created attachment 210146 [details]
Patch

[Darin Adler]

Comment on attachment 210146 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=210146&action=review

> Source/WebCore/platform/graphics/cairo/ImageBufferCairo.cpp:106
> +    UNUSED_PARAM(renderingMode);

I think ASSERT_UNUSED might be better here, since we know what value we support for rendering mode.

[Santosh Mahto]

Created attachment 210197 [details]
patch for landing

[WebKit Commit Bot]

Comment on attachment 210197 [details]
patch for landing

Rejecting attachment 210197 [details] from commit-queue.

[e-mail] does not have committer permissions according to http://trac.webkit.org/browser/trunk/Tools/Scripts/webkitpy/common/config/contributors.json.

- If you do not have committer rights please read http://webkit.org/coding/contributing.html for instructions on how to use bugzilla flags.

- If you have committer rights please correct the error in Tools/Scripts/webkitpy/common/config/contributors.json by adding yourself to the file (no review needed).  The commit-queue restarts itself every 2 hours.  After restart the commit-queue will correctly respect your committer rights.

[WebKit Commit Bot]

Comment on attachment 210197 [details]
patch for landing

Clearing flags on attachment: 210197

Committed r154936: <http://trac.webkit.org/changeset/154936>

[WebKit Commit Bot]

All reviewed patches have been landed.  Closing bug.