Summary: | [BlackBerry] Improved unproject algorithm | ||||||||
---|---|---|---|---|---|---|---|---|---|
Product: | WebKit | Reporter: | Arvid Nilsson <anilsson> | ||||||
Component: | WebKit BlackBerry | Assignee: | Arvid Nilsson <anilsson> | ||||||
Status: | RESOLVED INVALID | ||||||||
Severity: | Normal | CC: | andersca, anilsson, jkjiang, jpetsovits, rwlbuis | ||||||
Priority: | P2 | ||||||||
Version: | 528+ (Nightly build) | ||||||||
Hardware: | Unspecified | ||||||||
OS: | Unspecified | ||||||||
Bug Depends on: | 120362 | ||||||||
Bug Blocks: | |||||||||
Attachments: |
|
Description
Arvid Nilsson
2013-08-30 08:07:49 PDT
Created attachment 210112 [details]
Patch
Comment on attachment 210112 [details]
Patch
Looks good to me, r+ internally.
Comment on attachment 210112 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=210112&action=review Looks good. > Source/WebCore/ChangeLog:7 > + Internally reviewed by NOBODY (OOPS!). This line will probably not work, at least not with cq+, it should work when pushing by hand. Comment on attachment 210112 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=210112&action=review > Source/WebCore/platform/graphics/blackberry/LayerCompositingThread.cpp:135 > + m_modelViewTransform = projectionMatrix; Oops, I recreated this patch from memory for the review, but got this bit wrong - it's the model-view bit we want, not the projection bit! Should be m_modelViewTransform = matrix; > Source/WebCore/platform/graphics/blackberry/LayerUtilities.h:251 > + AffineTransform inverseProjectionMatrix(projectionMatrix.m11(), projectionMatrix.m21(), projectionMatrix.m21(), projectionMatrix.m22(), projectionMatrix.m41(), projectionMatrix.m42()); Typo, I wrote m21 twice... Should be AffineTransform inverseProjectionMatrix(projectionMatrix.m11(), projectionMatrix.m21(), projectionMatrix.m12(), projectionMatrix.m22(), projectionMatrix.m41(), projectionMatrix.m42()); Created attachment 210266 [details]
Patch
(In reply to comment #5) > Created an attachment (id=210266) [details] > Patch Fixed typos, sorry about those This is a followup to 120362 |