Bug 120494
| Summary: | Implement computed style for animation shorthand and align parsing with the spec | ||
|---|---|---|---|
| Product: | WebKit | Reporter: | Ryosuke Niwa <rniwa> |
| Component: | CSS | Assignee: | Nobody <webkit-unassigned> |
| Status: | NEW | ||
| Severity: | Normal | CC: | achicu, ahmad.saleem792, darin, dino, graouts, jonlee, koivisto, simon.fraser, syoichi |
| Priority: | P2 | Keywords: | BlinkMergeCandidate |
| Version: | 528+ (Nightly build) | ||
| Hardware: | Unspecified | ||
| OS: | Unspecified | ||
Ryosuke Niwa
Consider merging https://chromium.googlesource.com/chromium/blink/+/3eba59a6735370298e614f5e4d7a52abf7e185eb
Implement the computed style for the animation shorthand which will avoid
to return "".
Improve parsing of the shorthand by adding the play-state property part of the parsing. This align with the spec and it was changed at the end of last
year.
Remove dead code in CSSParser-in.cpp inherited from the transitions.
There are few commented tests that are not passing as they do not yet
align with the spec. It's a trickier issue that I will fix in a following patch (bug is linked).
| Attachments | ||
|---|---|---|
| Add attachment proposed patch, testcase, etc. |
Simon Fraser (smfr)
I added play-state parsing via bug 156959
Ahmad Saleem
Took tests from source.chromium.org:
Test Case - https://jsfiddle.net/jfo63L87/
^STP160 failing two
Test Case - 02 - https://jsfiddle.net/14d3xr0t/show
^STP160 failing one
Test Case - 03 - https://jsfiddle.net/gqwk1cuz/show
^STP160 failing two
Test Case - 04 - https://jsfiddle.net/kgtwjs3x/show
^STP160 failing three
Test Case - 05 - https://jsfiddle.net/grk78wtx/show
^STP160 fail both tests
______
Test from this patch:
JSFiddle - https://jsfiddle.net/2srtn3jy/show
Failing in STP160 compared to Chrome Canary 110 (not testing Firefox due to webkit prefix):
FAIL Object.keys(style).indexOf('animationName') should not be -1.
FAIL Object.keys(style).indexOf('webkitAnimationName') should not be -1.
FAIL Object.keys(style).indexOf('animationDuration') should not be -1.
FAIL Object.keys(style).indexOf('webkitAnimationDuration') should not be -1.
FAIL Object.keys(style).indexOf('animationTimingFunction') should not be -1.
FAIL Object.keys(style).indexOf('webkitAnimationTimingFunction') should not be -1.
FAIL style.animationTimingFunction should be step-start. Was steps(1, start).
FAIL style.webkitAnimationTimingFunction should be step-start. Was steps(1, start).
FAIL style.animationTimingFunction should be step-end. Was steps(1).
FAIL Object.keys(style).indexOf('animationDelay') should not be -1.
FAIL Object.keys(style).indexOf('webkitAnimationDelay') should not be -1.
FAIL Object.keys(style).indexOf('animationIterationCount') should not be -1.
FAIL Object.keys(style).indexOf('webkitAnimationIterationCount') should not be -1.
FAIL Object.keys(style).indexOf('animationDirection') should not be -1.
FAIL Object.keys(style).indexOf('webkitAnimationDirection') should not be -1.
FAIL Object.keys(style).indexOf('animationPlayState') should not be -1.
FAIL Object.keys(style).indexOf('webkitAnimationPlayState') should not be -1.
FAIL Object.keys(style).indexOf('animationFillMode') should not be -1.
FAIL Object.keys(style).indexOf('webkitAnimationFillMode') should not be -1.
and quite few more.
____
Just wanted to share updated testing result. Thanks!
Tim Nguyen (:ntim)
Darin, can this be closed with your recent changes?
Darin Adler
I didn’t make any improvements to computed style, so I’m guessing it’s not entirely right yet.