| Summary: | RenderBlock::calcMinMaxWidth() should not examine children of fixed-width blocks | ||||||
|---|---|---|---|---|---|---|---|
| Product: | WebKit | Reporter: | mitz | ||||
| Component: | Layout and Rendering | Assignee: | Nobody <webkit-unassigned> | ||||
| Status: | RESOLVED FIXED | ||||||
| Severity: | Normal | ||||||
| Priority: | P2 | ||||||
| Version: | 420+ | ||||||
| Hardware: | Mac | ||||||
| OS: | OS X 10.4 | ||||||
| Attachments: |
|
||||||
|
Description
mitz
2006-12-31 14:15:38 PST
Created attachment 12138 [details]
Optimize
Comment on attachment 12138 [details]
Optimize
No layout test regressions.
Comment on attachment 12138 [details]
Optimize
I started trickling support for the intrinsic and min-intrinsic keywords into flexible boxes. min-width: intrinsic, for example, would mean you need to check the kids still.
I'm not sure we need to deal with this now... but a FIXME reminding us that we need to deal with this issue when fully implementing these keywords might be helpful.
This optimization is valid for flexible boxes too. Another point to make is that I would like to eventually exclude "self-width/min-width/max-width" checks and only use them for your children (and not yourself). As long as they are included in self-calculations, flexible boxes will be broken. Anyway, just getting my thoughts down where someone else can absorb them. :) Comment on attachment 12138 [details]
Optimize
r=me
Committed revision 18497. |