Bug 120484

Summary: Web Inspector: Alt-up and Alt-down don't work when cursor is in unit
Product: WebKit Reporter: Timothy Hatcher <timothy>
Component: Web InspectorAssignee: Timothy Hatcher <timothy>
Status: RESOLVED FIXED    
Severity: Normal CC: graouts, joepeck, timothy, webkit-bug-importer
Priority: P2 Keywords: InRadar, Regression
Version: 528+ (Nightly build)   
Hardware: All   
OS: All   
Attachments:
Description Flags
Patch joepeck: review+

Timothy Hatcher
Reported 2013-08-29 12:32:48 PDT
Also Option-Up arrow in "translate3d" should not modify number to make" translate4d". <rdar://problem/13877085>
Attachments
Patch (4.63 KB, patch)
2013-08-29 12:37 PDT, Timothy Hatcher 		joepeck: review+
DetailsFormatted DiffDiff
View All Add attachment proposed patch, testcase, etc.
Timothy Hatcher
Comment 1 2013-08-29 12:37:21 PDT
Created attachment 210017 [details] Patch
Joseph Pecoraro
Comment 2 2013-08-29 15:52:33 PDT
Comment on attachment 210017 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=210017&action=review > Source/WebInspectorUI/UserInterface/CodeMirrorAdditions.js:387 > + var token = codeMirror.getTokenAt(position); > + if (token && token.type && /\bnumber\b/.test(token.type)) > + return token; It may be worth mentioning in a comment that CodeMirror outputs a single "number" token when CSS numbers are connected to units. It took me a while to figure out that "100px" is parsed as a single token in CodeMirror: Token: 'number' Position: '9' Stack: 'propertyValue' Current: '100px'
Timothy Hatcher
Comment 3 2013-08-30 11:24:07 PDT
http://trac.webkit.org/changeset/154897
Note You need to log in before you can comment on or make changes to this bug.