Bug 120483

Summary: Pasteboard::writeSelection violates layering (first step, fixes it for Mac platform only)
Product: WebKit Reporter: Darin Adler <darin>
Component: HTML EditingAssignee: Darin Adler <darin>
Status: RESOLVED FIXED    
Severity: Normal CC: webkit-ews
Priority: P2    
Version: 528+ (Nightly build)   
Hardware: All   
OS: All   
Attachments:
Description Flags
Patch andersca: review+, webkit-ews: commit-queue-

Darin Adler
Reported 2013-08-29 12:01:38 PDT
Pasteboard::writeSelection violates layering (first step, fixes it for Mac platform only)
Attachments
Patch (23.29 KB, patch)
2013-08-29 12:17 PDT, Darin Adler 		andersca: review+
webkit-ews: commit-queue-
DetailsFormatted DiffDiff
View All Add attachment proposed patch, testcase, etc.
Darin Adler
Comment 1 2013-08-29 12:17:39 PDT
Created attachment 210014 [details] Patch
Darin Adler
Comment 2 2013-08-29 12:18:30 PDT
Didn’t put [Mac] on the title because it touches cross-platform files a lot even though the only benefit is on Mac.
Anders Carlsson
Comment 3 2013-08-29 12:21:18 PDT
Comment on attachment 210014 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=210014&action=review > Source/WebCore/editing/Editor.h:45 > class NSDictionary; Should make this an OBJC_CLASS while you’re here.
Early Warning System Bot
Comment 4 2013-08-29 12:26:26 PDT
Comment on attachment 210014 [details] Patch Attachment 210014 [details] did not pass qt-ews (qt): Output: http://webkit-queues.appspot.com/results/1631292
Early Warning System Bot
Comment 5 2013-08-29 12:28:13 PDT
Comment on attachment 210014 [details] Patch Attachment 210014 [details] did not pass qt-wk2-ews (qt-wk2): Output: http://webkit-queues.appspot.com/results/1617014
Darin Adler
Comment 6 2013-08-29 13:08:15 PDT
Committed r154836: <http://trac.webkit.org/changeset/154836>
Note You need to log in before you can comment on or make changes to this bug.