Bug 120480 – Fix slider thumb event handling to use local, not absolute coordinates

• Component: New Bugs
• Status: RESOLVED FIXED

[Simon Fraser (smfr)]

Fix slider thumb event handling to use local, not absolute coordinates

[Simon Fraser (smfr)]

Created attachment 210002 [details]
Patch

[Early Warning System Bot]

Comment on attachment 210002 [details]
Patch

Attachment 210002 [details] did not pass qt-ews (qt):
Output: http://webkit-queues.appspot.com/results/1625625

[Early Warning System Bot]

Comment on attachment 210002 [details]
Patch

Attachment 210002 [details] did not pass qt-wk2-ews (qt-wk2):
Output: http://webkit-queues.appspot.com/results/1624681

[Simon Fraser (smfr)]

Created attachment 210004 [details]
Patch

[Darin Adler]

Comment on attachment 210004 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=210004&action=review

> Source/WebCore/ChangeLog:16
> +        No behavior change.

Is there any test coverage for this?

> Source/WebCore/html/shadow/SliderThumbElement.cpp:271
> +    RenderBox* inputRenderer = toRenderBox(input->renderer());
> +    RenderBox* trackRenderer = trackElement->renderBox();

In modern code we like to use references for things that can’t be null. I would use references for these two local variables.

[Simon Fraser (smfr)]

https://trac.webkit.org/r154832