Bug 120453

Summary:

CodeBlock::prepareForExecution() is silly

Product:

WebKit

Reporter:

Filip Pizlo <fpizlo>

Component:

JavaScriptCore

Assignee:

Filip Pizlo <fpizlo>

Status:

RESOLVED FIXED

Severity:

Normal

CC:

barraclough, commit-queue, ggaren, gyuyoung.kim, mark.lam, mhahnenberg, msaboff, oliver, rakuco, sam

Priority:

Version:

528+ (Nightly build)

Hardware:

All

OS:

All

Bug Depends on:

Bug Blocks:

112838

Attachments:

Description	Flags
the patch	none
rebased	oliver: review+

Filip Pizlo

Reported 2013-08-28 22:34:24 PDT

Why aren't we just calling into the appropriate execution engine to do the compilation? Beats me.

Attachments
the patch (49.71 KB, patch) 2013-08-28 22:36 PDT, Filip Pizlo	no flags	Details Formatted Diff Diff
rebased (50.23 KB, patch) 2013-08-29 11:29 PDT, Filip Pizlo	oliver: review+	Details Formatted Diff Diff
Show Obsolete (1) View All Add attachment proposed patch, testcase, etc.

Filip Pizlo

Comment 1 2013-08-28 22:36:27 PDT

Created attachment 209951 [details] the patch

WebKit Commit Bot

Comment 2 2013-08-28 22:38:24 PDT

Attachment 209951 [details] did not pass style-queue: Failed to run "['Tools/Scripts/check-webkit-style', '--diff-files', u'Source/JavaScriptCore/CMakeLists.txt', u'Source/JavaScriptCore/ChangeLog', u'Source/JavaScriptCore/GNUmakefile.list.am', u'Source/JavaScriptCore/JavaScriptCore.vcxproj/JavaScriptCore.vcxproj', u'Source/JavaScriptCore/JavaScriptCore.xcodeproj/project.pbxproj', u'Source/JavaScriptCore/Target.pri', u'Source/JavaScriptCore/bytecode/CodeBlock.cpp', u'Source/JavaScriptCore/bytecode/CodeBlock.h', u'Source/JavaScriptCore/dfg/DFGDriver.cpp', u'Source/JavaScriptCore/dfg/DFGDriver.h', u'Source/JavaScriptCore/dfg/DFGOSRExitPreparation.cpp', u'Source/JavaScriptCore/dfg/DFGWorklist.cpp', u'Source/JavaScriptCore/dfg/DFGWorklist.h', u'Source/JavaScriptCore/jit/JIT.cpp', u'Source/JavaScriptCore/jit/JIT.h', u'Source/JavaScriptCore/jit/JITStubs.cpp', u'Source/JavaScriptCore/llint/LLIntEntrypoint.cpp', u'Source/JavaScriptCore/llint/LLIntEntrypoint.h', u'Source/JavaScriptCore/llint/LLIntEntrypoints.cpp', u'Source/JavaScriptCore/llint/LLIntEntrypoints.h', u'Source/JavaScriptCore/llint/LLIntSlowPaths.cpp', u'Source/JavaScriptCore/runtime/Executable.cpp']" exit_code: 1 Source/JavaScriptCore/llint/LLIntEntrypoint.h:26: #ifndef header guard has wrong style, please use: LLIntEntrypoint_h [build/header_guard] [5] Total errors found: 1 in 18 files If any of these errors are false positives, please file a bug against check-webkit-style.

Filip Pizlo

Comment 3 2013-08-28 23:02:06 PDT

(In reply to comment #2) > Attachment 209951 [details] did not pass style-queue: > > Failed to run "['Tools/Scripts/check-webkit-style', '--diff-files', u'Source/JavaScriptCore/CMakeLists.txt', u'Source/JavaScriptCore/ChangeLog', u'Source/JavaScriptCore/GNUmakefile.list.am', u'Source/JavaScriptCore/JavaScriptCore.vcxproj/JavaScriptCore.vcxproj', u'Source/JavaScriptCore/JavaScriptCore.xcodeproj/project.pbxproj', u'Source/JavaScriptCore/Target.pri', u'Source/JavaScriptCore/bytecode/CodeBlock.cpp', u'Source/JavaScriptCore/bytecode/CodeBlock.h', u'Source/JavaScriptCore/dfg/DFGDriver.cpp', u'Source/JavaScriptCore/dfg/DFGDriver.h', u'Source/JavaScriptCore/dfg/DFGOSRExitPreparation.cpp', u'Source/JavaScriptCore/dfg/DFGWorklist.cpp', u'Source/JavaScriptCore/dfg/DFGWorklist.h', u'Source/JavaScriptCore/jit/JIT.cpp', u'Source/JavaScriptCore/jit/JIT.h', u'Source/JavaScriptCore/jit/JITStubs.cpp', u'Source/JavaScriptCore/llint/LLIntEntrypoint.cpp', u'Source/JavaScriptCore/llint/LLIntEntrypoint.h', u'Source/JavaScriptCore/llint/LLIntEntrypoints.cpp', u'Source/JavaScriptCore/llint/LLIntEntrypoints.h', u'Source/JavaScriptCore/llint/LLIntSlowPaths.cpp', u'Source/JavaScriptCore/runtime/Executable.cpp']" exit_code: 1 > Source/JavaScriptCore/llint/LLIntEntrypoint.h:26: #ifndef header guard has wrong style, please use: LLIntEntrypoint_h [build/header_guard] [5] Fixed. > Total errors found: 1 in 18 files > > > If any of these errors are false positives, please file a bug against check-webkit-style.

Filip Pizlo

Comment 4 2013-08-29 11:29:22 PDT

Created attachment 210005 [details] rebased

Oliver Hunt

Comment 5 2013-08-29 12:22:27 PDT

Comment on attachment 210005 [details] rebased yay!

Filip Pizlo

Comment 6 2013-08-29 12:28:29 PDT

Landed in http://trac.webkit.org/changeset/154833

Note You need to log in before you can comment on or make changes to this bug.