Bug 120386

Summary: Page::pluginData() should return a reference.
Product: WebKit Reporter: Andreas Kling <kling>
Component: Plug-insAssignee: Andreas Kling <kling>
Status: RESOLVED FIXED    
Severity: Normal CC: commit-queue, esprehn+autocc, japhet, kangil.han, webkit-ews
Priority: P2    
Version: 528+ (Nightly build)   
Hardware: Unspecified   
OS: Unspecified   
Attachments:
Description Flags
Patch
webkit-ews: commit-queue-
Patch
darin: review+
Patch none

Description Andreas Kling 2013-08-27 17:23:27 PDT 
Page::pluginData() should return a reference.
Comment 1 Andreas Kling 2013-08-27 17:30:02 PDT 
Created attachment 209826 [details]
Patch
Comment 2 Early Warning System Bot 2013-08-27 17:37:32 PDT 
Comment on attachment 209826 [details]
Patch

Attachment 209826 [details] did not pass qt-ews (qt):
Output: http://webkit-queues.appspot.com/results/1621096
Comment 3 Early Warning System Bot 2013-08-27 17:40:11 PDT 
Comment on attachment 209826 [details]
Patch

Attachment 209826 [details] did not pass qt-wk2-ews (qt-wk2):
Output: http://webkit-queues.appspot.com/results/1591394
Comment 4 Andreas Kling 2013-08-27 17:51:13 PDT 
Created attachment 209827 [details]
Patch
Comment 5 Darin Adler 2013-08-27 18:17:20 PDT 
Comment on attachment 209827 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=209827&action=review

> Source/WebCore/loader/SubframeLoader.cpp:197
> +    const PluginData& pluginData = page->pluginData();
> +    String pluginFile = pluginData.pluginFileForMimeType(newMIMEType);

Local variable not needed here. The old code had it to help it check against null.

> Source/WebCore/loader/SubframeLoader.cpp:418
> +        const PluginData& pluginData = m_frame->page()->pluginData();
> +        String pluginName = pluginData.pluginNameForMimeType(mimeType);

Local variable not needed here. The old code had it to help it check against null.

> Source/WebKit2/WebProcess/WebCoreSupport/WebFrameLoaderClient.cpp:1408
> +                const PluginData& pluginData = webPage->corePage()->pluginData();
> +                if (pluginSupportsExtension(pluginData, extension))

Local variable not needed here. The old code had it to help it check against null.
Comment 6 Andreas Kling 2013-08-28 06:39:34 PDT 
Created attachment 209875 [details]
Patch
Comment 7 WebKit Commit Bot 2013-08-28 07:10:43 PDT 
Comment on attachment 209875 [details]
Patch

Clearing flags on attachment: 209875

Committed r154743: <http://trac.webkit.org/changeset/154743>
Comment 8 WebKit Commit Bot 2013-08-28 07:10:47 PDT 
All reviewed patches have been landed.  Closing bug.