Summary: | Duplicate in-band tracks when switching <source> elements | ||||||||||||
---|---|---|---|---|---|---|---|---|---|---|---|---|---|
Product: | WebKit | Reporter: | Brendan Long <b.long> | ||||||||||
Component: | Media | Assignee: | Nobody <webkit-unassigned> | ||||||||||
Status: | RESOLVED FIXED | ||||||||||||
Severity: | Normal | CC: | buildbot, commit-queue, eric.carlson, esprehn+autocc, glenn, jer.noble, rniwa | ||||||||||
Priority: | P2 | ||||||||||||
Version: | 528+ (Nightly build) | ||||||||||||
Hardware: | Unspecified | ||||||||||||
OS: | Unspecified | ||||||||||||
Attachments: |
|
Description
Brendan Long
2013-08-27 11:18:02 PDT
Created attachment 209786 [details]
Patch
I'm building WebKit on a Mac so I can get the expected test results, it should be done by the time I get back from work. I tried building this on OSX with: Tools/Scripts/build-webkit --debug --video-track Then: Tools/Scripts/run-webkit-tests --debug LayoutTests/media/track/track-in-band-duplicate-tracks-when-source-changes.html Which results in a crash in DumpRenderTree, and if I use run-safari, it doesn't see the in-band tracks, and run-launcher doesn't seem to work (can't exec WebKitBuild/Debug: Permission Denied). It's possible my mac is broken somehow :\ Created attachment 209791 [details]
Updated patch
If the test uses reportExpected() instead of testExpected(), the number of in-band tracks won't be logged and we should be able to use the same test results for all ports that support in-band tracks.
(In reply to comment #4) > Created an attachment (id=209791) [details] > Updated patch > > If the test uses reportExpected() instead of testExpected(), the number of in-band tracks won't be logged and we should be able to use the same test results for all ports that support in-band tracks. Thanks for the suggestion. I might need to use that in the tests on my other patches too. Created attachment 209799 [details]
Add expected result file
I got the 'expected' file out of DumpRenderTree (which works perfectly for some reason, even though run-webkit-tests doesn't).
Wait, why does EWS say your patch passed, when my original patch got this output?
> Regressions: Unexpected missing results (1)
> media/track/track-in-band-duplicate-tracks-when-source-changes.html [ Missing ]
(In reply to comment #7) > Wait, why does EWS say your patch passed, when my original patch got this output? > > > Regressions: Unexpected missing results (1) > > media/track/track-in-band-duplicate-tracks-when-source-changes.html [ Missing ] Nevermind, I think I just didn't wait long enough. Comment on attachment 209791 [details] Updated patch Attachment 209791 [details] did not pass mac-ews (mac): Output: http://webkit-queues.appspot.com/results/1618043 New failing tests: media/track/track-in-band-duplicate-tracks-when-source-changes.html Created attachment 209802 [details]
Archive of layout-test-results from webkit-ews-01 for mac-mountainlion
The attached test failures were seen while running run-webkit-tests on the mac-ews.
Bot: webkit-ews-01 Port: mac-mountainlion Platform: Mac OS X 10.8.4
The buildbot errors were from the previous patch by the way. The current patch works. Comment on attachment 209799 [details] Add expected result file Clearing flags on attachment: 209799 Committed r154760: <http://trac.webkit.org/changeset/154760> All reviewed patches have been landed. Closing bug. The test added by this patch appears to have never passed on Lion: http://webkit-test-results.appspot.com/dashboards/flakiness_dashboard.html#showAllRuns=true&tests=media%2Ftrack%2Ftrack-in-band-duplicate-tracks-when-source-changes.html |