Bug 120365

Summary:

Remove unnecessary RenderView.h inclusion from headers.

Product:

WebKit

Reporter:

Andreas Kling <kling>

Component:

Layout and Rendering

Assignee:

Andreas Kling <kling>

Status:

RESOLVED FIXED

Severity:

Normal

CC:

commit-queue, eflews.bot, gyuyoung.kim, webkit-ews

Priority:

Version:

528+ (Nightly build)

Hardware:

Unspecified

OS:

Unspecified

Attachments:

Description	Flags
poch	andersca: review+, webkit-ews: commit-queue-
Patch för landning	webkit-ews: commit-queue-
Patch før lænding	buildbot: commit-queue-
Still landable?	none

Andreas Kling

Reported 2013-08-27 08:06:32 PDT

Remove unnecessary RenderView.h inclusion from headers.

Attachments
poch (3.21 KB, patch) 2013-08-27 08:07 PDT, Andreas Kling	andersca: review+ webkit-ews: commit-queue-	Details Formatted Diff Diff
Patch för landning (3.60 KB, patch) 2013-08-27 08:14 PDT, Andreas Kling	webkit-ews: commit-queue-	Details Formatted Diff Diff
Patch før lænding (4.44 KB, patch) 2013-08-27 08:30 PDT, Andreas Kling	buildbot: commit-queue-	Details Formatted Diff Diff
Still landable? (4.40 KB, patch) 2013-09-04 13:34 PDT, Andreas Kling	no flags	Details Formatted Diff Diff
Show Obsolete (3) View All Add attachment proposed patch, testcase, etc.

Andreas Kling

Comment 1 2013-08-27 08:07:02 PDT

Created attachment 209775 [details] poch

WebKit Commit Bot

Comment 2 2013-08-27 08:08:35 PDT

Attachment 209775 [details] did not pass style-queue: Failed to run "['Tools/Scripts/check-webkit-style', '--diff-files', u'Source/WebCore/ChangeLog', u'Source/WebCore/rendering/RenderMenuList.cpp', u'Source/WebCore/rendering/RenderQuote.cpp', u'Source/WebCore/rendering/RenderText.h', u'Source/WebCore/rendering/RenderTextTrackCue.cpp', u'Source/WebCore/rendering/RenderTextTrackCue.h', u'Source/WebCore/style/StyleResolveTree.cpp']" exit_code: 1 Source/WebCore/style/StyleResolveTree.cpp:39: Alphabetical sorting problem. [build/include_order] [4] Total errors found: 1 in 5 files If any of these errors are false positives, please file a bug against check-webkit-style.

Early Warning System Bot

Comment 3 2013-08-27 08:12:29 PDT

Comment on attachment 209775 [details] poch Attachment 209775 [details] did not pass qt-ews (qt): Output: http://webkit-queues.appspot.com/results/1579317

Early Warning System Bot

Comment 4 2013-08-27 08:12:42 PDT

Comment on attachment 209775 [details] poch Attachment 209775 [details] did not pass qt-wk2-ews (qt-wk2): Output: http://webkit-queues.appspot.com/results/1587311

Andreas Kling

Comment 5 2013-08-27 08:14:23 PDT

Created attachment 209776 [details] Patch för landning

Early Warning System Bot

Comment 6 2013-08-27 08:18:12 PDT

Comment on attachment 209776 [details] Patch för landning Attachment 209776 [details] did not pass qt-ews (qt): Output: http://webkit-queues.appspot.com/results/1588329