Bug 120354

Summary: [EFL] Added new accessibility expectations after r153798.
Product: WebKit Reporter: Krzysztof Czech <k.czech>
Component: WebKit EFLAssignee: Nobody <webkit-unassigned>
Status: RESOLVED FIXED    
Severity: Normal CC: aboxhall, apinheiro, cdumez, cfleizach, commit-queue, dmazzoni, gyuyoung.kim, jdiggs, lucas.de.marchi, mario, rakuco
Priority: P2    
Version: 528+ (Nightly build)   
Hardware: Unspecified   
OS: Linux   
Attachments:
Description Flags
Patch
none
Patch
none
Patch none

Krzysztof Czech
Reported 2013-08-27 05:01:19 PDT
r153432 made some regressions, r153798 has corrected the crashes. Provided patch corrected issues and added two more tests.
Attachments
Patch (18.61 KB, patch)
2013-08-27 05:08 PDT, Krzysztof Czech 		no flags
DetailsFormatted DiffDiff
Patch (18.28 KB, patch)
2013-08-27 05:18 PDT, Krzysztof Czech 		no flags
DetailsFormatted DiffDiff
Patch (18.29 KB, patch)
2013-08-27 06:01 PDT, Krzysztof Czech 		no flags
DetailsFormatted DiffDiff
Show Obsolete (2) View All Add attachment proposed patch, testcase, etc.
Krzysztof Czech
Comment 1 2013-08-27 05:08:12 PDT
Created attachment 209747 [details] Patch
Krzysztof Czech
Comment 2 2013-08-27 05:18:18 PDT
Created attachment 209749 [details] Patch
Chris Dumez
Comment 3 2013-08-27 05:36:51 PDT
Comment on attachment 209749 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=209749&action=review > LayoutTests/ChangeLog:3 > + [EFL] Fixed some accessibility tests after r153798 You're not really fixing anything, you are rebaselining / adding EFL-specific expectations.
Krzysztof Czech
Comment 4 2013-08-27 05:38:43 PDT
(In reply to comment #3) > (From update of attachment 209749 [details]) > View in context: https://bugs.webkit.org/attachment.cgi?id=209749&action=review > > > LayoutTests/ChangeLog:3 > > + [EFL] Fixed some accessibility tests after r153798 > > You're not really fixing anything, you are rebaselining / adding EFL-specific expectations. Thanks, I will correct this.
Krzysztof Czech
Comment 5 2013-08-27 06:01:18 PDT
Created attachment 209759 [details] Patch
WebKit Commit Bot
Comment 6 2013-08-27 06:40:05 PDT
Comment on attachment 209759 [details] Patch Clearing flags on attachment: 209759 Committed r154680: <http://trac.webkit.org/changeset/154680>
WebKit Commit Bot
Comment 7 2013-08-27 06:40:07 PDT
All reviewed patches have been landed. Closing bug.
Note You need to log in before you can comment on or make changes to this bug.