Summary: | Missing null-check of parent renderer in WebCore::HTMLEmbedElement::rendererIsNeeded() | ||||||||
---|---|---|---|---|---|---|---|---|---|
Product: | WebKit | Reporter: | Renata Hodovan <rhodovan.u-szeged> | ||||||
Component: | DOM | Assignee: | Renata Hodovan <rhodovan.u-szeged> | ||||||
Status: | RESOLVED FIXED | ||||||||
Severity: | Normal | CC: | aestes, commit-queue, esprehn+autocc, kling, rniwa, zalan | ||||||
Priority: | P2 | ||||||||
Version: | 528+ (Nightly build) | ||||||||
Hardware: | Unspecified | ||||||||
OS: | Unspecified | ||||||||
Bug Depends on: | |||||||||
Bug Blocks: | 116980 | ||||||||
Attachments: |
|
Description
Renata Hodovan
2013-08-27 01:00:00 PDT
Created attachment 209720 [details]
Test case
Created attachment 209721 [details]
Proposed patch
Not sure about the early return. This changes the functionality when useFallbackContent==true, though the same time the non-existing parent renderer might indicate that we dont need the fallback content either. It does, however, end up returning false, when the parent is <object> as opposed to when the parent is something else with the same non-renderer status. CCed Andy, he might have some insights as he added the fallback check. Comment on attachment 209721 [details] Proposed patch Clearing flags on attachment: 209721 Committed r154698: <http://trac.webkit.org/changeset/154698> All reviewed patches have been landed. Closing bug. |