Summary: | FocusController::focusedOrMainFrame() should return a reference. | ||||||||||||
---|---|---|---|---|---|---|---|---|---|---|---|---|---|
Product: | WebKit | Reporter: | Andreas Kling <kling> | ||||||||||
Component: | WebCore Misc. | Assignee: | Andreas Kling <kling> | ||||||||||
Status: | RESOLVED FIXED | ||||||||||||
Severity: | Normal | CC: | darin, eflews.bot, gtk-ews, gyuyoung.kim, kling, rego+ews, webkit-ews, xan.lopez | ||||||||||
Priority: | P2 | ||||||||||||
Version: | 528+ (Nightly build) | ||||||||||||
Hardware: | Unspecified | ||||||||||||
OS: | Unspecified | ||||||||||||
Attachments: |
|
Description
Andreas Kling
2013-08-26 20:33:09 PDT
Created attachment 209711 [details]
Patch
I'm sure EWS will hate it. I like it though.
Comment on attachment 209711 [details] Patch Attachment 209711 [details] did not pass qt-wk2-ews (qt-wk2): Output: http://webkit-queues.appspot.com/results/1590139 Comment on attachment 209711 [details] Patch Attachment 209711 [details] did not pass efl-ews (efl): Output: http://webkit-queues.appspot.com/results/1578160 Comment on attachment 209711 [details] Patch Attachment 209711 [details] did not pass qt-ews (qt): Output: http://webkit-queues.appspot.com/results/1582153 Created attachment 209713 [details]
Patch
Comment on attachment 209713 [details] Patch Attachment 209713 [details] did not pass qt-ews (qt): Output: http://webkit-queues.appspot.com/results/1589136 Comment on attachment 209713 [details] Patch Attachment 209713 [details] did not pass efl-ews (efl): Output: http://webkit-queues.appspot.com/results/1581145 Comment on attachment 209713 [details] Patch Attachment 209713 [details] did not pass qt-wk2-ews (qt-wk2): Output: http://webkit-queues.appspot.com/results/1586135 Comment on attachment 209713 [details] Patch Attachment 209713 [details] did not pass gtk-ews (gtk): Output: http://webkit-queues.appspot.com/results/1578166 Created attachment 209714 [details]
Patch
Comment on attachment 209714 [details] Patch Attachment 209714 [details] did not pass efl-ews (efl): Output: http://webkit-queues.appspot.com/results/1578170 Comment on attachment 209714 [details] Patch Attachment 209714 [details] did not pass qt-wk2-ews (qt-wk2): Output: http://webkit-queues.appspot.com/results/1583139 /mnt/eflews/webkit/WebKit/Source/WebKit/efl/ewk/ewk_view.cpp: In function 'Evas_Object* ewk_view_frame_focused_get(const Evas_Object*)': /mnt/eflews/webkit/WebKit/Source/WebKit/efl/ewk/ewk_view.cpp:1400:94: error: request for member 'loader' in 'core', which is of pointer type 'WebCore::Frame*' (maybe you meant to use '->' ?) /home/webkit/WebKit/Source/WebKit2/WebProcess/WebPage/WebPage.cpp: In member function 'WebKit::EditorState WebKit::WebPage::editorState() const': /home/webkit/WebKit/Source/WebKit2/WebProcess/WebPage/WebPage.cpp:615:35: error: base operand of '->' has non-pointer type 'WebCore::Frame' and more of the same Comment on attachment 209714 [details] Patch Attachment 209714 [details] did not pass win-ews (win): Output: http://webkit-queues.appspot.com/results/1579257 Created attachment 209750 [details]
Patch
Comment on attachment 209750 [details]
Patch
r=me
Committed r154678: <http://trac.webkit.org/changeset/154678> |