Bug 120325

Summary: Editor::spellChecker() should return a reference
Product: WebKit Reporter: Sam Weinig <sam>
Component: New BugsAssignee: Sam Weinig <sam>
Status: RESOLVED FIXED    
Severity: Normal    
Priority: P2    
Version: 528+ (Nightly build)   
Hardware: Unspecified   
OS: Unspecified   
Attachments:
Description Flags
Patch andersca: review+

Description Sam Weinig 2013-08-26 14:46:46 PDT 
Editor::spellChecker() should return a reference
Comment 1 Sam Weinig 2013-08-26 14:47:36 PDT 
Created attachment 209679 [details]
Patch
Comment 2 Andreas Kling 2013-08-26 14:49:25 PDT 
Comment on attachment 209679 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=209679&action=review

r=me

> Source/WebCore/editing/Editor.h:332
> -    SpellChecker* spellChecker() const { return m_spellChecker.get(); }
> +    SpellChecker& spellChecker() const { return *m_spellChecker.get(); }

You should make m_spellChecker a "const OwnPtr" so it can't be assigned to after construction, too.
Comment 3 Sam Weinig 2013-08-26 14:49:27 PDT 
Committed r154643: <http://trac.webkit.org/changeset/154643>
Comment 4 Darin Adler 2013-08-26 15:17:15 PDT 
Comment on attachment 209679 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=209679&action=review

>> Source/WebCore/editing/Editor.h:332
>> +    SpellChecker& spellChecker() const { return *m_spellChecker.get(); }
> 
> You should make m_spellChecker a "const OwnPtr" so it can't be assigned to after construction, too.

No need for get() here.