Bug 120325

Summary: Editor::spellChecker() should return a reference
Product: WebKit Reporter: Sam Weinig <sam>
Component: New BugsAssignee: Sam Weinig <sam>
Status: RESOLVED FIXED    
Severity: Normal    
Priority: P2    
Version: 528+ (Nightly build)   
Hardware: Unspecified   
OS: Unspecified   
Attachments:
Description Flags
Patch andersca: review+

Sam Weinig
Reported 2013-08-26 14:46:46 PDT
Editor::spellChecker() should return a reference
Attachments
Patch (6.80 KB, patch)
2013-08-26 14:47 PDT, Sam Weinig 		andersca: review+
DetailsFormatted DiffDiff
View All Add attachment proposed patch, testcase, etc.
Sam Weinig
Comment 1 2013-08-26 14:47:36 PDT
Created attachment 209679 [details] Patch
Andreas Kling
Comment 2 2013-08-26 14:49:25 PDT
Comment on attachment 209679 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=209679&action=review r=me > Source/WebCore/editing/Editor.h:332 > - SpellChecker* spellChecker() const { return m_spellChecker.get(); } > + SpellChecker& spellChecker() const { return *m_spellChecker.get(); } You should make m_spellChecker a "const OwnPtr" so it can't be assigned to after construction, too.
Sam Weinig
Comment 3 2013-08-26 14:49:27 PDT
Committed r154643: <http://trac.webkit.org/changeset/154643>
Darin Adler
Comment 4 2013-08-26 15:17:15 PDT
Comment on attachment 209679 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=209679&action=review >> Source/WebCore/editing/Editor.h:332 >> + SpellChecker& spellChecker() const { return *m_spellChecker.get(); } > > You should make m_spellChecker a "const OwnPtr" so it can't be assigned to after construction, too. No need for get() here.
Note You need to log in before you can comment on or make changes to this bug.