Bug 120304

Summary:

Document's renderer is always a RenderView.

Product:

WebKit

Reporter:

Andreas Kling <kling>

Component:

Layout and Rendering

Assignee:

Andreas Kling <kling>

Status:

RESOLVED FIXED

Severity:

Normal

CC:

commit-queue, d-r, esprehn+autocc, fmalita, glenn, kangil.han, kling, kondapallykalyan, pdr, schenney

Priority:

Version:

528+ (Nightly build)

Hardware:

Unspecified

OS:

Unspecified

Attachments:

Description	Flags
"Patch"	darin: review+

Description Andreas Kling 2013-08-26 06:09:38 PDT

Compile-time enforcement: Document's renderer is always a RenderView.

Comment 1 Andreas Kling 2013-08-26 06:48:31 PDT

Created attachment 209648 [details]
"Patch"

Comment 2 Darin Adler 2013-08-26 10:02:55 PDT

Comment on attachment 209648 [details]
"Patch"

View in context: https://bugs.webkit.org/attachment.cgi?id=209648&action=review

> Source/WebCore/dom/Document.h:1195
> +    void setRenderer(RenderObject*) WTF_DELETED_FUNCTION;

I suggest leaving out the argument:

    void setRenderer() WTF_DELETED_FUNCTION;

Makes it even less likely someone can call it by accident in a compiler that doesn't support deleting functions.

Comment 3 Andreas Kling 2013-08-27 05:31:45 PDT

Committed r154676: <http://trac.webkit.org/changeset/154676>