Bug 120292

Summary:

[GTK] Improve the stop/reload button implementation in MiniBrowser

Product:

WebKit

Reporter:

Carlos Garcia Campos <cgarcia>

Component:

Tools / Tests

Assignee:

Nobody <webkit-unassigned>

Status:

RESOLVED FIXED

Severity:

Normal

CC:

pnormand

Priority:

Version:

528+ (Nightly build)

Hardware:

Unspecified

OS:

Unspecified

Attachments:

Description	Flags
Patch	pnormand: review+

Description Carlos Garcia Campos 2013-08-26 01:47:30 PDT

- Use an instance member of BrowserWindow for the button widget instead of a global variable
 - Use notify::is-loading to monitor the WebView load instead of the estimated-load-progress property
 - Use webkit_web_view_is_loading() to check whether the view loading to change the button icon instead of a string comparison of the gtk stock icon id

Comment 1 Carlos Garcia Campos 2013-08-26 01:48:06 PDT

And use the right casts to avoid compile warnings

Comment 2 Carlos Garcia Campos 2013-08-26 01:51:00 PDT

Created attachment 209627 [details]
Patch

Comment 3 Sergio Villar Senin 2013-08-26 02:09:35 PDT

Comment on attachment 209627 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=209627&action=review

Patch looks awesome to me.

> Tools/ChangeLog:13
> +          loading to change the button icon instead of a string

nit: an 'is' is missing here?

Comment 4 Philippe Normand 2013-08-26 03:21:43 PDT

Comment on attachment 209627 [details]
Patch

Yep please fix this small nit spotted by Sergio :)

Comment 5 Carlos Garcia Campos 2013-08-26 03:30:37 PDT

Committed r154594: <http://trac.webkit.org/changeset/154594>