Bug 120276

Summary:

RenderLayer::renderer() should return a reference.

Product:

WebKit

Reporter:

Andreas Kling <kling>

Component:

Layout and Rendering

Assignee:

Andreas Kling <kling>

Status:

RESOLVED FIXED

Severity:

Normal

CC:

commit-queue, dino, eflews.bot, esprehn+autocc, glenn, gtk-ews, gyuyoung.kim, kondapallykalyan, philn, simon.fraser, WebkitBugTracker, xan.lopez

Priority:

Version:

528+ (Nightly build)

Hardware:

Unspecified

OS:

Unspecified

Attachments:

Description	Flags
Patch	eflews.bot: commit-queue-
Patch	none

Description Andreas Kling 2013-08-25 15:52:24 PDT

There is always a renderer.

Comment 1 Andreas Kling 2013-08-25 15:58:47 PDT

Created attachment 209605 [details]
Patch

Comment 2 WebKit Commit Bot 2013-08-25 16:01:48 PDT

Attachment 209605 [details] did not pass style-queue:

Failed to run "['Tools/Scripts/check-webkit-style', '--diff-files', u'Source/WebCore/ChangeLog', u'Source/WebCore/inspector/InspectorLayerTreeAgent.cpp', u'Source/WebCore/page/FrameView.cpp', u'Source/WebCore/rendering/FilterEffectRenderer.cpp', u'Source/WebCore/rendering/RenderBlock.cpp', u'Source/WebCore/rendering/RenderBoxModelObject.cpp', u'Source/WebCore/rendering/RenderEmbeddedObject.cpp', u'Source/WebCore/rendering/RenderFlowThread.cpp', u'Source/WebCore/rendering/RenderGeometryMap.cpp', u'Source/WebCore/rendering/RenderLayer.cpp', u'Source/WebCore/rendering/RenderLayer.h', u'Source/WebCore/rendering/RenderLayerBacking.cpp', u'Source/WebCore/rendering/RenderLayerBacking.h', u'Source/WebCore/rendering/RenderLayerCompositor.cpp', u'Source/WebCore/rendering/RenderLayerFilterInfo.cpp', u'Source/WebCore/rendering/RenderLayerModelObject.cpp', u'Source/WebCore/rendering/RenderMarquee.cpp', u'Source/WebCore/rendering/RenderObject.cpp', u'Source/WebCore/rendering/RenderText.cpp', u'Source/WebCore/rendering/RenderTreeAsText.cpp', u'Source/WebKit/mac/WebView/WebRenderLayer.mm', u'Source/WebKit2/Shared/WebRenderLayer.cpp']" exit_code: 1
Source/WebCore/rendering/RenderLayer.cpp:2613:  Weird number of spaces at line-start.  Are you using a 4-space indent?  [whitespace/indent] [3]
Source/WebCore/rendering/RenderLayer.cpp:5844:  When wrapping a line, only indent 4 spaces.  [whitespace/indent] [3]
Total errors found: 2 in 22 files


If any of these errors are false positives, please file a bug against check-webkit-style.

Comment 3 EFL EWS Bot 2013-08-25 16:07:48 PDT

Comment on attachment 209605 [details]
Patch

Attachment 209605 [details] did not pass efl-wk2-ews (efl-wk2):
Output: http://webkit-queues.appspot.com/results/1557861

Comment 4 kov's GTK+ EWS bot 2013-08-25 16:08:40 PDT

Comment on attachment 209605 [details]
Patch

Attachment 209605 [details] did not pass gtk-ews (gtk):
Output: http://webkit-queues.appspot.com/results/1562491

Comment 5 Andreas Kling 2013-08-25 16:12:12 PDT

Created attachment 209608 [details]
Patch

Comment 6 WebKit Commit Bot 2013-08-25 16:13:55 PDT

Attachment 209608 [details] did not pass style-queue:

Failed to run "['Tools/Scripts/check-webkit-style', '--diff-files', u'Source/WebCore/ChangeLog', u'Source/WebCore/inspector/InspectorLayerTreeAgent.cpp', u'Source/WebCore/page/FrameView.cpp', u'Source/WebCore/page/GestureTapHighlighter.cpp', u'Source/WebCore/rendering/FilterEffectRenderer.cpp', u'Source/WebCore/rendering/RenderBlock.cpp', u'Source/WebCore/rendering/RenderBoxModelObject.cpp', u'Source/WebCore/rendering/RenderEmbeddedObject.cpp', u'Source/WebCore/rendering/RenderFlowThread.cpp', u'Source/WebCore/rendering/RenderGeometryMap.cpp', u'Source/WebCore/rendering/RenderLayer.cpp', u'Source/WebCore/rendering/RenderLayer.h', u'Source/WebCore/rendering/RenderLayerBacking.cpp', u'Source/WebCore/rendering/RenderLayerBacking.h', u'Source/WebCore/rendering/RenderLayerCompositor.cpp', u'Source/WebCore/rendering/RenderLayerFilterInfo.cpp', u'Source/WebCore/rendering/RenderLayerModelObject.cpp', u'Source/WebCore/rendering/RenderMarquee.cpp', u'Source/WebCore/rendering/RenderObject.cpp', u'Source/WebCore/rendering/RenderText.cpp', u'Source/WebCore/rendering/RenderTreeAsText.cpp', u'Source/WebKit/mac/WebView/WebRenderLayer.mm', u'Source/WebKit2/Shared/WebRenderLayer.cpp']" exit_code: 1
Source/WebCore/rendering/RenderLayer.cpp:5863:  Line contains only semicolon. If this should be an empty statement, use { } instead.  [whitespace/semicolon] [5]
Total errors found: 1 in 23 files


If any of these errors are false positives, please file a bug against check-webkit-style.

Comment 7 WebKit Commit Bot 2013-08-25 18:01:31 PDT

Comment on attachment 209608 [details]
Patch

Clearing flags on attachment: 209608

Committed r154583: <http://trac.webkit.org/changeset/154583>

Comment 8 WebKit Commit Bot 2013-08-25 18:01:35 PDT

All reviewed patches have been landed.  Closing bug.