Bug 120272

Summary: RenderObject::document() should return a reference.
Product: WebKit Reporter: Andreas Kling <kling>
Component: Layout and RenderingAssignee: Andreas Kling <kling>
Status: RESOLVED FIXED    
Severity: Normal CC: buildbot, commit-queue, ddkilzer, rniwa, webkit-ews
Priority: P2    
Version: 528+ (Nightly build)   
Hardware: Unspecified   
OS: Unspecified   
Attachments:
Description Flags
EWS experiment
webkit-ews: commit-queue-
EWS experiment 2
none
Patch none

Description Andreas Kling 2013-08-25 04:45:17 PDT 
RenderObject::document() should return a reference.
Comment 1 Andreas Kling 2013-08-25 04:45:51 PDT 
Created attachment 209588 [details]
EWS experiment
Comment 2 WebKit Commit Bot 2013-08-25 04:48:34 PDT 
Attachment 209588 [details] did not pass style-queue:

Failed to run "['Tools/Scripts/check-webkit-style', '--diff-files', u'Source/WebCore/accessibility/AXObjectCache.cpp', u'Source/WebCore/accessibility/AccessibilityARIAGrid.cpp', u'Source/WebCore/accessibility/AccessibilityListBox.cpp', u'Source/WebCore/accessibility/AccessibilityListBoxOption.cpp', u'Source/WebCore/accessibility/AccessibilityMenuList.cpp', u'Source/WebCore/accessibility/AccessibilityObject.cpp', u'Source/WebCore/accessibility/AccessibilityRenderObject.cpp', u'Source/WebCore/accessibility/AccessibilitySlider.cpp', u'Source/WebCore/accessibility/AccessibilityTable.cpp', u'Source/WebCore/accessibility/mac/WebAccessibilityObjectWrapperMac.mm', u'Source/WebCore/css/CSSCanvasValue.cpp', u'Source/WebCore/css/CSSCanvasValue.h', u'Source/WebCore/css/CSSCrossfadeValue.cpp', u'Source/WebCore/css/CSSFilterImageValue.cpp', u'Source/WebCore/css/CSSGradientValue.cpp', u'Source/WebCore/html/HTMLInputElement.cpp', u'Source/WebCore/html/HTMLSelectElement.cpp', u'Source/WebCore/page/FrameView.cpp', u'Source/WebCore/page/Page.cpp', u'Source/WebCore/page/animation/AnimationController.cpp', u'Source/WebCore/page/animation/ImplicitAnimation.cpp', u'Source/WebCore/page/animation/KeyframeAnimation.cpp', u'Source/WebCore/rendering/AutoTableLayout.cpp', u'Source/WebCore/rendering/FilterEffectRenderer.cpp', u'Source/WebCore/rendering/FlowThreadController.cpp', u'Source/WebCore/rendering/InlineFlowBox.cpp', u'Source/WebCore/rendering/InlineTextBox.cpp', u'Source/WebCore/rendering/RenderBR.cpp', u'Source/WebCore/rendering/RenderBlock.cpp', u'Source/WebCore/rendering/RenderBlockLineLayout.cpp', u'Source/WebCore/rendering/RenderBox.cpp', u'Source/WebCore/rendering/RenderBox.h', u'Source/WebCore/rendering/RenderBoxModelObject.cpp', u'Source/WebCore/rendering/RenderButton.cpp', u'Source/WebCore/rendering/RenderDeprecatedFlexibleBox.cpp', u'Source/WebCore/rendering/RenderEmbeddedObject.cpp', u'Source/WebCore/rendering/RenderFrameSet.cpp', u'Source/WebCore/rendering/RenderFullScreen.cpp', u'Source/WebCore/rendering/RenderImage.cpp', u'Source/WebCore/rendering/RenderInline.cpp', u'Source/WebCore/rendering/RenderLayer.cpp', u'Source/WebCore/rendering/RenderLayerBacking.cpp', u'Source/WebCore/rendering/RenderLayerCompositor.cpp', u'Source/WebCore/rendering/RenderListBox.cpp', u'Source/WebCore/rendering/RenderListItem.cpp', u'Source/WebCore/rendering/RenderListMarker.cpp', u'Source/WebCore/rendering/RenderMarquee.cpp', u'Source/WebCore/rendering/RenderMenuList.cpp', u'Source/WebCore/rendering/RenderMultiColumnBlock.cpp', u'Source/WebCore/rendering/RenderMultiColumnSet.cpp', u'Source/WebCore/rendering/RenderNamedFlowThread.cpp', u'Source/WebCore/rendering/RenderObject.cpp', u'Source/WebCore/rendering/RenderObject.h', u'Source/WebCore/rendering/RenderObjectChildList.cpp', u'Source/WebCore/rendering/RenderRegion.cpp', u'Source/WebCore/rendering/RenderReplaced.cpp', u'Source/WebCore/rendering/RenderRuby.cpp', u'Source/WebCore/rendering/RenderRubyRun.cpp', u'Source/WebCore/rendering/RenderScrollbar.cpp', u'Source/WebCore/rendering/RenderSearchField.cpp', u'Source/WebCore/rendering/RenderSnapshottedPlugIn.cpp', u'Source/WebCore/rendering/RenderTable.cpp', u'Source/WebCore/rendering/RenderTableCell.cpp', u'Source/WebCore/rendering/RenderTableCell.h', u'Source/WebCore/rendering/RenderTableRow.cpp', u'Source/WebCore/rendering/RenderTableSection.cpp', u'Source/WebCore/rendering/RenderText.cpp', u'Source/WebCore/rendering/RenderTextControl.cpp', u'Source/WebCore/rendering/RenderTextControlSingleLine.cpp', u'Source/WebCore/rendering/RenderTheme.cpp', u'Source/WebCore/rendering/RenderVideo.cpp', u'Source/WebCore/rendering/RenderView.cpp', u'Source/WebCore/rendering/RenderWidget.cpp', u'Source/WebCore/rendering/RootInlineBox.cpp', u'Source/WebCore/rendering/mathml/RenderMathMLBlock.cpp', u'Source/WebCore/rendering/mathml/RenderMathMLRow.cpp', u'Source/WebCore/rendering/svg/RenderSVGInlineText.cpp', u'Source/WebCore/rendering/svg/RenderSVGResource.cpp', u'Source/WebCore/rendering/svg/RenderSVGResourceFilter.cpp', u'Source/WebCore/rendering/svg/RenderSVGRoot.cpp', u'Source/WebCore/rendering/svg/SVGInlineFlowBox.cpp', u'Source/WebCore/rendering/svg/SVGInlineTextBox.cpp', u'Source/WebCore/rendering/svg/SVGRenderTreeAsText.cpp', u'Source/WebCore/rendering/svg/SVGResources.cpp', u'Source/WebCore/rendering/svg/SVGResourcesCache.cpp', u'Source/WebCore/rendering/svg/SVGRootInlineBox.cpp']" exit_code: 1
Source/WebCore/rendering/RenderBox.cpp:428:  Boolean expressions that span multiple lines should have their operators on the left side of the line instead of the right side.  [whitespace/operators] [4]
Source/WebCore/rendering/RenderBox.cpp:429:  Boolean expressions that span multiple lines should have their operators on the left side of the line instead of the right side.  [whitespace/operators] [4]
Source/WebCore/rendering/RenderObject.cpp:2338:  Boolean expressions that span multiple lines should have their operators on the left side of the line instead of the right side.  [whitespace/operators] [4]
Total errors found: 3 in 86 files


If any of these errors are false positives, please file a bug against check-webkit-style.
Comment 3 Early Warning System Bot 2013-08-25 04:56:46 PDT 
Comment on attachment 209588 [details]
EWS experiment

Attachment 209588 [details] did not pass qt-ews (qt):
Output: http://webkit-queues.appspot.com/results/1564187
Comment 4 Early Warning System Bot 2013-08-25 04:58:20 PDT 
Comment on attachment 209588 [details]
EWS experiment

Attachment 209588 [details] did not pass qt-wk2-ews (qt-wk2):
Output: http://webkit-queues.appspot.com/results/1542868
Comment 5 Build Bot 2013-08-25 05:00:09 PDT 
Comment on attachment 209588 [details]
EWS experiment

Attachment 209588 [details] did not pass mac-wk2-ews (mac-wk2):
Output: http://webkit-queues.appspot.com/results/1544877
Comment 6 Andreas Kling 2013-08-25 05:06:33 PDT 
Created attachment 209590 [details]
EWS experiment 2
Comment 7 Andreas Kling 2013-08-25 13:36:03 PDT 
Created attachment 209601 [details]
Patch
Comment 8 Antti Koivisto 2013-08-25 13:37:22 PDT 
Comment on attachment 209601 [details]
Patch

r=me, nice!
Comment 9 WebKit Commit Bot 2013-08-25 14:21:04 PDT 
Comment on attachment 209601 [details]
Patch

Clearing flags on attachment: 209601

Committed r154580: <http://trac.webkit.org/changeset/154580>
Comment 10 WebKit Commit Bot 2013-08-25 14:21:06 PDT 
All reviewed patches have been landed.  Closing bug.
Comment 11 David Kilzer (:ddkilzer) 2013-08-26 09:27:31 PDT 
(In reply to comment #9)
> (From update of attachment 209601 [details])
> Clearing flags on attachment: 209601
> 
> Committed r154580: <http://trac.webkit.org/changeset/154580>

iOS BUILD FIX in r154608.  <http://trac.webkit.org/r154608>