Bug 120268

Summary: [WebKit2] Offsets for WKBundlePageLoaderClient in APIClientTraits are wrong
Product: WebKit Reporter: Carlos Garcia Campos <cgarcia>
Component: WebKit2Assignee: Nobody <webkit-unassigned>
Status: RESOLVED FIXED    
Severity: Normal CC: andersca, ap, zan
Priority: P2    
Version: 528+ (Nightly build)   
Hardware: Unspecified   
OS: Unspecified   
Bug Depends on:    
Bug Blocks: 103377    
Attachments:
Description Flags
Patch andersca: review+

Description Carlos Garcia Campos 2013-08-25 02:20:55 PDT 
In r129810 a new offset was added for didLayout, but the offset of registerIntentServiceForFrame was added instead. Since then all other offsets look wrong because the last offset of the previous version is used instead of the first offset of the current version.
Comment 1 Carlos Garcia Campos 2013-08-25 02:24:10 PDT 
Created attachment 209580 [details]
Patch

I think this will fix the unit tests currently failing in mac
Comment 2 Zan Dobersek 2013-08-25 12:04:50 PDT 
I can confirm the patch fixes the unit tests on the GTK port.
Comment 3 Carlos Garcia Campos 2013-08-26 08:01:44 PDT 
Committed r154602: <http://trac.webkit.org/changeset/154602>
Comment 4 Alexey Proskuryakov 2013-08-26 09:40:52 PDT 
What were the tests failing on Mac? I'm puzzled because this fixed a year old regression, did we have those tests failing for a year?
Comment 5 Carlos Garcia Campos 2013-08-26 11:19:47 PDT 
(In reply to comment #4)
> What were the tests failing on Mac? I'm puzzled because this fixed a year old regression, did we have those tests failing for a year?

I think it only affected to clients using a specific version of the API, versions < 6, the test failing were using version 6, and they started to fail when version 7 was added.