Bug 120262

Summary:

No need for documentTypeString function in Frame

Product:

WebKit

Reporter:

Darin Adler <darin>

Component:

HTML Editing

Assignee:

Darin Adler <darin>

Status:

RESOLVED FIXED

Severity:

Normal

CC:

buildbot, commit-queue, rniwa

Priority:

Version:

528+ (Nightly build)

Hardware:

All

OS:

All

Attachments:

Description	Flags
Patch	none
Archive of layout-test-results from webkit-ews-04 for mac-mountainlion	none
Patch	none

Darin Adler

Reported 2013-08-24 23:41:24 PDT

Frame should not have a documentTypeString member function

Attachments
Patch (11.50 KB, patch) 2013-08-24 23:51 PDT, Darin Adler	no flags	Details Formatted Diff Diff
Archive of layout-test-results from webkit-ews-04 for mac-mountainlion (264.69 KB, application/zip) 2013-08-25 00:29 PDT, Build Bot	no flags	Details
Patch (11.49 KB, patch) 2013-08-25 01:15 PDT, Darin Adler	no flags	Details Formatted Diff Diff
Show Obsolete (1) View All Add attachment proposed patch, testcase, etc.

Darin Adler

Comment 1 2013-08-24 23:51:38 PDT

Created attachment 209572 [details] Patch

Build Bot

Comment 2 2013-08-25 00:29:09 PDT

Comment on attachment 209572 [details] Patch Attachment 209572 [details] did not pass mac-ews (mac): Output: http://webkit-queues.appspot.com/results/1555779 New failing tests: editing/pasteboard/5761530-1.html editing/pasteboard/4944770-2.html editing/execCommand/find-after-replace.html editing/spelling/grammar-markers.html editing/selection/4895428-1.html http/tests/inspector/inspect-element.html editing/inserting/insert-3786362-fix.html editing/pasteboard/4242293.html editing/spelling/grammar-markers-hidpi.html editing/pasteboard/5028447.html editing/selection/4895428-4.html editing/execCommand/paste-1.html editing/inserting/insert-3907422-fix.html editing/inserting/insert-paste-bidi-control.html editing/pasteboard/5601583-1.html editing/style/5065910.html editing/style/font-family-with-space.html editing/pasteboard/5075944.html editing/pasteboard/19644-2.html editing/pasteboard/5065605.html editing/deleting/paste-with-transparent-background-color.html editing/pasteboard/4922709.html editing/pasteboard/4989774.html editing/pasteboard/19644-1.html editing/style/non-inheritable-styles.html editing/pasteboard/4944770-1.html editing/pasteboard/4242293-1.html editing/input/reveal-contenteditable-on-paste-vertically.html editing/pasteboard/5071074.html editing/pasteboard/4641033.html

Build Bot

Comment 3 2013-08-25 00:29:10 PDT

Created attachment 209574 [details] Archive of layout-test-results from webkit-ews-04 for mac-mountainlion The attached test failures were seen while running run-webkit-tests on the mac-ews. Bot: webkit-ews-04 Port: mac-mountainlion Platform: Mac OS X 10.8.4

Darin Adler

Comment 4 2013-08-25 01:15:31 PDT

Created attachment 209576 [details] Patch

WebKit Commit Bot

Comment 5 2013-08-25 03:14:37 PDT

Comment on attachment 209576 [details] Patch Clearing flags on attachment: 209576 Committed r154575: <http://trac.webkit.org/changeset/154575>

WebKit Commit Bot

Comment 6 2013-08-25 03:14:40 PDT

All reviewed patches have been landed. Closing bug.

Note You need to log in before you can comment on or make changes to this bug.