Bug 120257

Summary:

Move Frame::inScope into FrameTree

Product:

WebKit

Reporter:

Darin Adler <darin>

Component:

New Bugs

Assignee:

Darin Adler <darin>

Status:

RESOLVED FIXED

Severity:

Normal

CC:

buildbot, commit-queue, eflews.bot, gyuyoung.kim, philn, rniwa, webkit-ews, xan.lopez

Priority:

Version:

528+ (Nightly build)

Hardware:

Unspecified

OS:

Unspecified

Attachments:

Description	Flags
Patch	none
Patch	sam: review+, commit-queue: commit-queue-

Darin Adler

Reported 2013-08-24 17:45:59 PDT

Move Frame::inScope into FrameTree

Attachments
Patch (4.45 KB, patch) 2013-08-24 17:47 PDT, Darin Adler	no flags	Details Formatted Diff Diff
Patch (5.08 KB, patch) 2013-08-24 18:57 PDT, Darin Adler	sam: review+ commit-queue: commit-queue-	Details Formatted Diff Diff
Show Obsolete (1) View All Add attachment proposed patch, testcase, etc.

Darin Adler

Comment 1 2013-08-24 17:47:32 PDT

Created attachment 209564 [details] Patch

Early Warning System Bot

Comment 2 2013-08-24 17:57:06 PDT

Comment on attachment 209564 [details] Patch Attachment 209564 [details] did not pass qt-ews (qt): Output: http://webkit-queues.appspot.com/results/1564048

Early Warning System Bot

Comment 3 2013-08-24 17:58:32 PDT

Comment on attachment 209564 [details] Patch Attachment 209564 [details] did not pass qt-wk2-ews (qt-wk2): Output: http://webkit-queues.appspot.com/results/1565006

Build Bot

Comment 4 2013-08-24 17:59:30 PDT

Comment on attachment 209564 [details] Patch Attachment 209564 [details] did not pass mac-wk2-ews (mac-wk2): Output: http://webkit-queues.appspot.com/results/1565004

Build Bot

Comment 5 2013-08-24 18:33:07 PDT

Comment on attachment 209564 [details] Patch Attachment 209564 [details] did not pass mac-ews (mac): Output: http://webkit-queues.appspot.com/results/1555696

EFL EWS Bot

Comment 6 2013-08-24 18:34:49 PDT

Comment on attachment 209564 [details] Patch Attachment 209564 [details] did not pass efl-ews (efl): Output: http://webkit-queues.appspot.com/results/1559424

EFL EWS Bot

Comment 7 2013-08-24 18:40:25 PDT

Comment on attachment 209564 [details] Patch Attachment 209564 [details] did not pass efl-wk2-ews (efl-wk2): Output: http://webkit-queues.appspot.com/results/1557609

Darin Adler

Comment 8 2013-08-24 18:57:10 PDT

Created attachment 209568 [details] Patch

WebKit Commit Bot

Comment 9 2013-08-24 20:38:13 PDT

Comment on attachment 209568 [details] Patch Rejecting attachment 209568 [details] from commit-queue. Failed to run "['/Volumes/Data/EWS/WebKit/Tools/Scripts/webkit-patch', '--status-host=webkit-queues.appspot.com', '--bot-id=webkit-cq-03', 'apply-attachment', '--no-update', '--non-interactive', 209568, '--port=mac']" exit_code: 2 cwd: /Volumes/Data/EWS/WebKit Last 500 characters of output: /WebCore/ChangeLog Hunk #1 succeeded at 1 with fuzz 3. patching file Source/WebCore/page/Frame.cpp patching file Source/WebCore/page/Frame.h patching file Source/WebCore/page/FrameTree.cpp Hunk #4 FAILED at 189. Hunk #5 FAILED at 204. Hunk #6 FAILED at 218. 3 out of 6 hunks FAILED -- saving rejects to file Source/WebCore/page/FrameTree.cpp.rej Failed to run "[u'/Volumes/Data/EWS/WebKit/Tools/Scripts/svn-apply', '--force', '--reviewer', u'Sam Weinig']" exit_code: 1 cwd: /Volumes/Data/EWS/WebKit Full output: http://webkit-queues.appspot.com/results/1555731

Darin Adler

Comment 10 2013-08-24 20:39:58 PDT

Committed r154560: <http://trac.webkit.org/changeset/154560>

Note You need to log in before you can comment on or make changes to this bug.