Bug 120247

Summary: RenderObject::view() should return a reference.
Product: WebKit Reporter: Andreas Kling <kling>
Component: Layout and RenderingAssignee: Andreas Kling <kling>
Status: RESOLVED FIXED    
Severity: Normal CC: commit-queue, eflews.bot, gyuyoung.kim, kling, philn, xan.lopez
Priority: P2    
Version: 528+ (Nightly build)   
Hardware: Unspecified   
OS: Unspecified   
Attachments:
Description Flags
EWS experiment
eflews.bot: commit-queue-
Patch koivisto: review+

Description Andreas Kling 2013-08-24 05:43:01 PDT 
& stuff.
Comment 1 Andreas Kling 2013-08-24 05:43:42 PDT 
Created attachment 209540 [details]
EWS experiment
Comment 2 WebKit Commit Bot 2013-08-24 05:44:47 PDT 
Attachment 209540 [details] did not pass style-queue:

Failed to run "['Tools/Scripts/check-webkit-style', '--diff-files', u'Source/WebCore/accessibility/AXObjectCache.cpp', u'Source/WebCore/accessibility/AccessibilityRenderObject.cpp', u'Source/WebCore/html/HTMLMediaElement.cpp', u'Source/WebCore/page/FrameView.cpp', u'Source/WebCore/page/Page.cpp', u'Source/WebCore/page/animation/AnimationController.cpp', u'Source/WebCore/rendering/InlineFlowBox.cpp', u'Source/WebCore/rendering/LayoutState.cpp', u'Source/WebCore/rendering/RenderBR.cpp', u'Source/WebCore/rendering/RenderBlock.cpp', u'Source/WebCore/rendering/RenderBlockLineLayout.cpp', u'Source/WebCore/rendering/RenderBox.cpp', u'Source/WebCore/rendering/RenderBox.h', u'Source/WebCore/rendering/RenderBoxModelObject.cpp', u'Source/WebCore/rendering/RenderCounter.cpp', u'Source/WebCore/rendering/RenderDeprecatedFlexibleBox.cpp', u'Source/WebCore/rendering/RenderEmbeddedObject.cpp', u'Source/WebCore/rendering/RenderFlexibleBox.cpp', u'Source/WebCore/rendering/RenderFlowThread.cpp', u'Source/WebCore/rendering/RenderFrameSet.cpp', u'Source/WebCore/rendering/RenderGrid.cpp', u'Source/WebCore/rendering/RenderHTMLCanvas.cpp', u'Source/WebCore/rendering/RenderImage.cpp', u'Source/WebCore/rendering/RenderInline.cpp', u'Source/WebCore/rendering/RenderLayer.cpp', u'Source/WebCore/rendering/RenderLayerBacking.cpp', u'Source/WebCore/rendering/RenderLayerModelObject.cpp', u'Source/WebCore/rendering/RenderLineBoxList.cpp', u'Source/WebCore/rendering/RenderListBox.cpp', u'Source/WebCore/rendering/RenderListItem.cpp', u'Source/WebCore/rendering/RenderMarquee.cpp', u'Source/WebCore/rendering/RenderMedia.cpp', u'Source/WebCore/rendering/RenderMediaControlElements.cpp', u'Source/WebCore/rendering/RenderMenuList.cpp', u'Source/WebCore/rendering/RenderNamedFlowThread.cpp', u'Source/WebCore/rendering/RenderObject.cpp', u'Source/WebCore/rendering/RenderObject.h', u'Source/WebCore/rendering/RenderObjectChildList.cpp', u'Source/WebCore/rendering/RenderQuote.cpp', u'Source/WebCore/rendering/RenderRegion.cpp', u'Source/WebCore/rendering/RenderReplaced.cpp', u'Source/WebCore/rendering/RenderScrollbarPart.cpp', u'Source/WebCore/rendering/RenderTable.cpp', u'Source/WebCore/rendering/RenderTableCell.cpp', u'Source/WebCore/rendering/RenderTableCell.h', u'Source/WebCore/rendering/RenderTableRow.cpp', u'Source/WebCore/rendering/RenderTableSection.cpp', u'Source/WebCore/rendering/RenderText.cpp', u'Source/WebCore/rendering/RenderText.h', u'Source/WebCore/rendering/RenderTextTrackCue.cpp', u'Source/WebCore/rendering/RenderTheme.cpp', u'Source/WebCore/rendering/RenderThemeMac.mm', u'Source/WebCore/rendering/RenderView.cpp', u'Source/WebCore/rendering/RenderWidget.cpp', u'Source/WebCore/rendering/RootInlineBox.cpp', u'Source/WebCore/rendering/mathml/RenderMathMLBlock.cpp', u'Source/WebCore/rendering/svg/RenderSVGContainer.cpp', u'Source/WebCore/rendering/svg/RenderSVGForeignObject.cpp', u'Source/WebCore/rendering/svg/RenderSVGResourceContainer.cpp', u'Source/WebCore/rendering/svg/RenderSVGRoot.cpp', u'Source/WebKit/mac/Plugins/WebBaseNetscapePluginView.mm', u'Source/WebKit/mac/WebView/WebFullScreenController.mm', u'Source/WebKit2/WebProcess/FullScreen/WebFullScreenManager.cpp']" exit_code: 1
Source/WebCore/rendering/RenderLayer.cpp:943:  Weird number of spaces at line-start.  Are you using a 4-space indent?  [whitespace/indent] [3]
Source/WebCore/rendering/RenderLayer.cpp:1006:  Weird number of spaces at line-start.  Are you using a 4-space indent?  [whitespace/indent] [3]
Source/WebCore/rendering/RenderBoxModelObject.cpp:2630:  Weird number of spaces at line-start.  Are you using a 4-space indent?  [whitespace/indent] [3]
Total errors found: 3 in 63 files


If any of these errors are false positives, please file a bug against check-webkit-style.
Comment 3 EFL EWS Bot 2013-08-24 06:12:46 PDT 
Comment on attachment 209540 [details]
EWS experiment

Attachment 209540 [details] did not pass efl-ews (efl):
Output: http://webkit-queues.appspot.com/results/1526962
Comment 4 EFL EWS Bot 2013-08-24 06:30:29 PDT 
Comment on attachment 209540 [details]
EWS experiment

Attachment 209540 [details] did not pass efl-wk2-ews (efl-wk2):
Output: http://webkit-queues.appspot.com/results/1529848
Comment 5 Andreas Kling 2013-08-24 06:55:41 PDT 
Created attachment 209541 [details]
Patch
Comment 6 Antti Koivisto 2013-08-24 07:05:40 PDT 
Comment on attachment 209541 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=209541&action=review

> Source/WebCore/rendering/RenderBR.cpp:56
> -        m_lineHeight = style()->computedLineHeight(view());
> +        m_lineHeight = style()->computedLineHeight(&view());

I foresee more patches!
Comment 7 Andreas Kling 2013-08-24 09:35:51 PDT 
Committed r154546: <http://trac.webkit.org/changeset/154546>